RawConnection.php: add workgroup to auth file #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From what I understood after some googling (haven't been able to reproduce the original problem to test) is that the domain option in the auth file is pretty much ignored and that you should set the |
icewind1991
force-pushed
the
master
branch
2 times, most recently
from
6889d88 to
82f9618
Compare
icewind1991
force-pushed
the
master
branch
2 times, most recently
from
e1438ac to
6691355
Compare
icewind1991
force-pushed
the
master
branch
4 times, most recently
from
eda3870 to
29bdeba
Compare
icewind1991
force-pushed
the
master
branch
3 times, most recently
from
c1a84fc to
0fc2a08
Compare
icewind1991
force-pushed
the
master
branch
7 times, most recently
from
e4b0bcd to
80a4edf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I read somewhere in a discussion about libsmbclient-php that people were having trouble with SMB and workgroups when using the
smbclientbinary. Maybe it's because the workgroup parameter is not being passed tosmbclientin the auth file? This pull request, which is based on similar code in SambaDAV, adds support for that parameter. Beware that I haven't actually tested or ran this code.