Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Implicit Connection with Secure Data #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

simy307
Copy link

@simy307 simy307 commented May 23, 2018

Currently a connection can be made with the "Implicit" option. However the data being transferred is not encrypted and an error would be passed down from the server

522 Data connections must be encrypted

This change would allow a connection with both an "Implicit" connection type and "Secure" data.

Copy link
Owner

@icetee icetee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for the PR! I try to test it soon.

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "@icetee/ftp",
"version": "1.0.2",
"version": "1.0.3",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please no change version number!

@icetee
Copy link
Owner

icetee commented Jun 16, 2018

I watched your code, but is the same as if I set "secure": true. If true, then encrypted data and commucation channel.

Otherwise, I get an error:

events.js:167
      throw er; // Unhandled 'error' event
      ^

Error: 11000:error:1408F10B:SSL routines:ssl3_get_record:wrong version number:openssl\ssl\record\ssl3_record.c:252:

    at Socket.ondata (internal/wrap_js_stream.js:62:22)
    at Socket.emit (events.js:182:13)
    at addChunk (_stream_readable.js:280:12)
    at readableAddChunk (_stream_readable.js:265:11)
    at Socket.Readable.push (_stream_readable.js:220:10)
    at TCP.onread (net.js:638:20)
Emitted 'error' event at:
    at TLSSocket.onerror (D:\DEV\_forks\node-ftp\lib\connection.js:311:10)
    at TLSSocket.emit (events.js:182:13)
    at emitErrorNT (internal/streams/destroy.js:92:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
    at process._tickCallback (internal/process/next_tick.js:174:19)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants