Feat add eslint-plugin-prettier

packages/eslint-plugin-best-practices/CHANGELOG.md

@@ -1,5 +1,8 @@
 # changelog
 
+## 0.3.0
+- Add `eslint-plugin-prettier`
+
 ## 0.2.10
 - Update stylistic rules `dot-notation` and `@typescript-eslint/dot-notation` from error to off.
 

packages/eslint-plugin-best-practices/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@iceworks/eslint-plugin-best-practices",
-  "version": "0.2.10",
+  "version": "0.3.0",
   "description": "Iceworks best practices eslint plugin.",
   "files": [
     "docs/",

packages/eslint-plugin-best-practices/src/configs/common.js

@@ -1,5 +1,5 @@
 module.exports = {
-  plugins: ['@iceworks/best-practices'],
+  plugins: ['prettier', '@iceworks/best-practices'],
   overrides: [
     {
       files: ['package.json'],
@@ -18,26 +18,28 @@ module.exports = {
       },
     },
     {
-      files: [
-        '**/__tests__/*.{j,t}s?(x)',
-        '**/tests/*.{j,t}s?(x)',
-        '**/test/*.{j,t}s?(x)',
-      ],
+      files: ['**/__tests__/*.{j,t}s?(x)', '**/tests/*.{j,t}s?(x)', '**/test/*.{j,t}s?(x)'],
       env: { jest: true },
     },
   ],
   rules: {
+    semi: 'warn',
     'dot-notation': 'off',
-    'max-len': ['warn', 120, 2, {
-      ignoreUrls: true,
-      ignoreComments: false,
-      ignoreRegExpLiterals: true,
-      ignoreStrings: true,
-      ignoreTemplateLiterals: true,
-    }],
-    'semi': 'warn',
+    'max-len': [
+      'warn',
+      120,
+      2,
+      {
+        ignoreUrls: true,
+        ignoreComments: false,
+        ignoreRegExpLiterals: true,
+        ignoreStrings: true,
+        ignoreTemplateLiterals: true,
+      },
+    ],
     'eol-last': 'warn',
     'quote-props': 'warn',
+    'prettier/prettier': 'warn',
     '@iceworks/best-practices/no-http-url': 'warn',
     '@iceworks/best-practices/no-js-in-ts-project': 'warn',
     '@iceworks/best-practices/no-lowercase-component-name': 'warn',

packages/eslint-plugin-best-practices/src/configs/rax-ts.js

@@ -3,10 +3,10 @@ const { deepmerge } = require('@iceworks/spec');
 
 module.exports = deepmerge(commonConfig, {
   rules: {
+    semi: 'off',
     'max-lines': ['warn', { max: 500 }],
     'no-plusplus': 'off',
     'no-return-await': 'off',
-    'semi': 'off',
     '@typescript-eslint/dot-notation': 'off',
     '@typescript-eslint/semi': 'warn',
     '@typescript-eslint/no-unused-vars': 'warn',

packages/eslint-plugin-best-practices/src/configs/react-ts.js

@@ -3,12 +3,12 @@ const { deepmerge } = require('@iceworks/spec');
 
 module.exports = deepmerge(commonConfig, {
   rules: {
+    semi: 'off',
     'max-len': ['error', { code: 150 }],
     'max-lines': ['warn', { max: 500 }],
     'no-plusplus': 'off',
     'no-return-await': 'off',
     'react/prop-types': 'off',
-    'semi': 'off',
     '@typescript-eslint/dot-notation': 'off',
     '@typescript-eslint/semi': 'warn',
     '@typescript-eslint/no-unused-vars': 'warn',

packages/eslint-plugin-best-practices/src/rules/no-broad-semantic-versioning.js

@@ -47,12 +47,7 @@ module.exports = {
                 dependencyVersion.indexOf('>') > -1
               ) {
                 let newVersioning = '^1.0.0';
-                const dependencyPackageFile = path.join(
-                  cwd,
-                  'node_modules',
-                  dependencyName,
-                  'package.json',
-                );
+                const dependencyPackageFile = path.join(cwd, 'node_modules', dependencyName, 'package.json');
                 if (fs.existsSync(dependencyPackageFile)) {
                   const dependencyPackage = fs.readJSONSync(dependencyPackageFile);
                   newVersioning = `^${dependencyPackage.version}`;

packages/eslint-plugin-best-practices/src/rules/no-secret-info.js

@@ -1,3 +1,4 @@
+/* eslint-disable prettier/prettier */
 const docsUrl = require('../docsUrl');
 
 const RULE_NAME = 'no-secret-info';

packages/eslint-plugin-best-practices/src/rules/recommend-polyfill.js

@@ -72,12 +72,7 @@ module.exports = {
           const supports = target.__compat.support;
           for (let i = 0, l = Object.keys(targetBrowsers).length; i < l; i++) {
             const browser = Object.keys(targetBrowsers)[i];
-            if (
-              semver.satisfies(
-                `${targetBrowsers[browser]}.0.0`,
-                `<${supports[browser].version_added}`,
-              )
-            ) {
+            if (semver.satisfies(`${targetBrowsers[browser]}.0.0`, `<${supports[browser].version_added}`)) {
               context.report({
                 node,
                 messageId: 'recommendPolyfill',

packages/spec/CHANGELOG.md

@@ -1,5 +1,9 @@
 # changelog
 
+## 1.5.1
+
+- Feat add `eslint-plugin-prettier`, and set `"prettier/prettier": "warn"`.
+
 ## 1.5.0
 
 - Feat update eslint-config-ali, babel and typescript dependencies to support [email protected].

packages/spec/examples/rax/index.jsx

@@ -10,3 +10,15 @@ export default (props) => {
   const source = { uri };
   return <Image className="logo" source={source} />;
 };
+
+// prettier test
+const a = 1; const b = 2;
+const c = {
+  a: [
+    {
+      a: 1,
+      b:
+        2,
+    },
+  ],
+}

packages/spec/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@iceworks/spec",
-  "version": "1.5.0",
+  "version": "1.5.1",
   "description": "Easy to use eslint/stylelint/prettier/commitlint in rax, ice and react project.",
   "main": "src/index.js",
   "files": [
@@ -36,16 +36,17 @@
     "stylelint": ">=8.3.0"
   },
   "dependencies": {
-    "@iceworks/eslint-plugin-best-practices": "^0.2.0",
-    "@typescript-eslint/eslint-plugin": "^5.0.0",
-    "@typescript-eslint/parser": "^5.0.0",
     "@babel/core": "^7.16.0",
     "@babel/eslint-parser": "^7.16.3",
     "@babel/preset-react": "^7.16.0",
+    "@iceworks/eslint-plugin-best-practices": "^0.3.0",
+    "@typescript-eslint/eslint-plugin": "^5.0.0",
+    "@typescript-eslint/parser": "^5.0.0",
     "commitlint-config-ali": "^0.1.0",
     "eslint-config-ali": "^13.0.0",
     "eslint-plugin-import": "^2.22.1",
     "eslint-plugin-jsx-plus": "^0.1.0",
+    "eslint-plugin-prettier": "^4.0.0",
     "eslint-plugin-rax-compile-time-miniapp": "^1.0.0",
     "eslint-plugin-react": "^7.21.5",
     "eslint-plugin-react-hooks": "^4.2.0",

packages/spec/src/eslint/common-ts.js

@@ -1,12 +1,10 @@
 // https://www.npmjs.com/package/eslint-config-ali
 // ESlint config for common ts project
 module.exports = {
-  extends: [
-    require.resolve('eslint-config-ali/typescript'),
-  ],
+  extends: [require.resolve('eslint-config-ali/typescript')],
   rules: {
     // Change error to warn
-    'semi': 'off',
+    semi: 'off',
     '@typescript-eslint/semi': 'warn',
     'eol-last': 'warn',
     'quote-props': 'warn',

packages/spec/src/eslint/common.js

@@ -1,12 +1,10 @@
 // https://www.npmjs.com/package/eslint-config-ali
 // ESlint config for common js project
 module.exports = {
-  extends: [
-    require.resolve('eslint-config-ali'),
-  ],
+  extends: [require.resolve('eslint-config-ali')],
   rules: {
     // Change error to warn
-    'semi': 'warn',
+    semi: 'warn',
     'eol-last': 'warn',
     'quote-props': 'warn',
     'no-unused-vars': 'warn',

packages/spec/src/eslint/vue-ts.js

@@ -1,12 +1,10 @@
 // https://www.npmjs.com/package/eslint-config-ali
 // ESlint config for Vue TypeScript project
 module.exports = {
-  extends: [
-    require.resolve('eslint-config-ali/typescript/vue'),
-  ],
+  extends: [require.resolve('eslint-config-ali/typescript/vue')],
   rules: {
     // Change error to warn
-    'semi': 'off',
+    semi: 'off',
     '@typescript-eslint/semi': 'warn',
     'eol-last': 'warn',
     'quote-props': 'warn',

packages/spec/src/eslint/vue.js

@@ -1,12 +1,10 @@
 // https://www.npmjs.com/package/eslint-config-ali
 // ESlint config for Vue project
 module.exports = {
-  extends: [
-    require.resolve('eslint-config-ali/vue'),
-  ],
+  extends: [require.resolve('eslint-config-ali/vue')],
   rules: {
     // Change error to warn
-    'semi': 'warn',
+    semi: 'warn',
     'eol-last': 'warn',
     'quote-props': 'warn',
     'no-unused-vars': 'warn',

packages/spec/src/getRaxEslintConfig.js

@@ -9,13 +9,13 @@ module.exports = function (config) {
     const buildConfigFilePath = path.join(process.cwd(), 'build.json');
 
     if (fs.existsSync(buildConfigFilePath)) {
-
       const buildConfig = JSON5.parse(fs.readFileSync(buildConfigFilePath, 'utf8'));
 
-      const isCompileTime = (target) => (
-        buildConfig.targets && buildConfig.targets.find((t) => t === target) &&
-        buildConfig[target] && buildConfig[target].buildType === 'compile'
-      );
+      const isCompileTime = (target) =>
+        buildConfig.targets &&
+        buildConfig.targets.find((t) => t === target) &&
+        buildConfig[target] &&
+        buildConfig[target].buildType === 'compile';
 
       // At present, only miniapp and wechat-miniprogram support build for compile-time
       if (isCompileTime('miniapp') || isCompileTime('wechat-miniprogram')) {