Pull request update/231220 #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle cases where there is insufficient space for a menu by dynamically adjusting the layout. This involves adding a bottom margin for tables increasing the OptScale widget height to accommodate additional space.
Included `excludeMyself` to `useApiState(GET_POOL_OWNERS, { poolId, excludeMyself })` in `useGetPoolOwners` hook
Also fixed selector loader label in `PoolFormTypeSelector` component
## Description Make pylint tests work: gemini ## Related issue number OS-7092 ## Checklist * [ ] The pull request title is a good summary of the changes * [ ] Unit tests for the changes exist * [ ] New and existing unit tests pass locally
## Description previously we ran tests only for the worker ## Related issue number OS-7101 ## Checklist * [ ] The pull request title is a good summary of the changes * [ ] Unit tests for the changes exist * [ ] New and existing unit tests pass locally
## Description Upgrade cryptography to eliminate dependabot issues ## Related issue number OS-7113 ## Checklist * [x] The pull request title is a good summary of the changes * [ ] Unit tests for the changes exist * [ ] New and existing unit tests pass locally
## Description Add diworker migrations to pylint tests Upgrade pylint version Upgrade pep8 to Pycodestyle ## Related issue number OS-6621 ## Checklist * [ ] The pull request title is a good summary of the changes * [ ] Unit tests for the changes exist * [ ] New and existing unit tests pass locally
With create-react-app the `homepage` option from `package.json` was used - https://create-react-app.dev/docs/deployment/#building-for-relative-paths With vite we need to specify the `base` config option for nested path - https://vitejs.dev/guide/build#public-base-path
maxb-hystax
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
af02fb2 OS-7181: Added disable fix for checkbox
05d56db OS-7040. Define 'base' config option
611aa35 OS-7177: Linting fix
77f6b00 OS-7177: Temporary solution for default selector values
d528e3d OS-6621. Add diworker migrations to pylint tests
d4aef9d OS-7176: Updated MUI packages
8e75e67 OS-7113. Updated cryptography package
c7a6390 OS-7101. pylint and pep8 tests for risp scheduler and worker
730e806 OS-7092. Make pylint tests work: gemini
115fd1e OS-6627. Force header help icon to always have the secondary.main color
c576867 OS-7050. Fixed hash calculation for getPoolOwners
0cbf057 OS-7042. Migrate storybook to vite
d3e2539 OS-7045. Update axios, graphql, graphql-ws, and @apollo/server
625a71e OS-7040. Update jira_ui packages, regenerate package-lock file, migrate to vite
0f1889b OS-6625: Remove geminis after organization deletion
8d488d5 OS-7037. Dynamically allocate space for dropdown men