Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bbs Scheme #39

Merged
merged 5 commits into from
Dec 17, 2024
Merged

Bbs Scheme #39

merged 5 commits into from
Dec 17, 2024

Conversation

mikelodder7
Copy link
Contributor

Adds BBS signature scheme and abstracts the signature scheme to be pluggable.

@mikelodder7
Copy link
Contributor Author

Looks like we need to update the rust version

Signed-off-by: Michael Lodder <[email protected]>
Signed-off-by: Michael Lodder <[email protected]>
Signed-off-by: Michael Lodder <[email protected]>
Signed-off-by: Michael Lodder <[email protected]>
Signed-off-by: Michael Lodder <[email protected]>
@swcurran
Copy link
Member

Hey @mikelodder7 — a couple of questions, only one relevant to the merge:

  • are all of the AnonCreds v2 ZK features supported? Same as PS?
  • Revocation? Is that impacted, or is it still the same.
  • I tried to look for tests and I see some that are BBS, but not sure. Are all of the tests run for both PS and BBS signatures?

It’s the last one that is relevant to the PR. The others are documentation :-)

This is awesome to see!

@mikelodder7
Copy link
Contributor Author

Hey @mikelodder7 — a couple of questions, only one relevant to the merge:

  • are all of the AnonCreds v2 ZK features supported? Same as PS?

Yes they are swappable.

  • Revocation? Is that impacted, or is it still the same.

Revocation works the same regardless of which one is used.

  • I tried to look for tests and I see some that are BBS, but not sure. Are all of the tests run for both PS and BBS signatures?

You see some used in flow.rs and other places. They both still work no matter which scheme is used.

It’s the last one that is relevant to the PR. The others are documentation :-)

This is awesome to see!

@swcurran swcurran merged commit 42840a9 into hyperledger:main Dec 17, 2024
6 checks passed
@mikelodder7 mikelodder7 deleted the ml/bbs branch December 17, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants