refactor: remove index Assets in AssetsMap by AssetDefinitionId #4701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DCNick3
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
Erigara,
0x009922,
VAmuzing and
dima74
as code owners
DCNick3
force-pushed
the
remove-redundant-key-in-assets-map
branch
from
9dbdc47 to
ca6ed1f
Compare
DCNick3
force-pushed
the
remove-redundant-key-in-assets-map
branch
from
ca6ed1f to
f787554
Compare
mversic
approved these changes
Jun 6, 2024
Erigara
approved these changes
Jun 6, 2024
AssetsMap stores assets for a particular account, so indexing them via AssetId (which is AccountId + AssetDefinitionId) is redundant Also remove some unnecessary AccoundId clones Signed-off-by: ⭐️NINIKA⭐️ <[email protected]>
DCNick3
force-pushed
the
remove-redundant-key-in-assets-map
branch
from
f787554 to
53668dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AssetsMap stores assets for a particular account, so indexing them via AssetId (which is AccountId + AssetDefinitionId) is redundant
Also remove some unnecessary AccoundId clones
Linked issue
Closes #4700
Benefits
A bit more efficient, allows for more efficient implementations testing whether an account has some asset or not.
Checklist