fix: Correct default value for JsonString
#4692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erigara
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
0x009922,
DCNick3,
VAmuzing and
dima74
as code owners
mversic
approved these changes
Jun 5, 2024
0x009922
approved these changes
Jun 6, 2024
nxsaken
approved these changes
Jun 6, 2024
Signed-off-by: Shanin Roman <[email protected]>
nxsaken
force-pushed
the
fix_json_string_default
branch
from
7a0c14a to
0af5d4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set
"null"as default value forJsonStringinstead of""which is not valid json.Linked issue
Closes #4686
How to test