Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] #4126: test to prevent cross chain replay attacks #4219

Closed
wants to merge 11 commits into from
Closed

[refactor] #4126: test to prevent cross chain replay attacks #4219

wants to merge 11 commits into from

Conversation

timofeevmd
Copy link
Contributor

Description

Linked issue

Closes #{issue_number}

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Jan 19, 2024
@Erigara
Copy link
Contributor

Erigara commented Jan 19, 2024

We have the following format for commits:

[type] #<issue number>: Description

Please sign-off your commits by git commit -s.

You can find more in CONTRIBUTING.md.

@Erigara
Copy link
Contributor

Erigara commented Jan 19, 2024

error: function `send_tx_with_different_ChainId` should have a snake case name
  --> client/tests/integration/asset.rs:15:4
   |
15 | fn send_tx_with_different_ChainId() -> Result<()> {
   |    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `send_tx_with_different_chain_id`
   |
   = note: `-D non-snake-case` implied by `-D nonstandard-style`
   = help: to override `-D nonstandard-style` add `#[allow(non_snake_case)]`

Rename to send_tx_with_different_chain_id.

@Erigara Erigara self-assigned this Jan 19, 2024
@Erigara Erigara changed the title chain_id test was created [refactor] hyperledger#4126: test to prevent cross chain replay attacks Jan 23, 2024
@Erigara Erigara changed the title [refactor] hyperledger#4126: test to prevent cross chain replay attacks [refactor] #4126: test to prevent cross chain replay attacks Jan 23, 2024
@Erigara
Copy link
Contributor

Erigara commented Jan 23, 2024

Please squash your commit either locally of before merge

@Asem-Abdelhady
Copy link
Contributor

Don't forget to rebase the upstream iroha2-dev into your PR. I could see that some commits of your are not signed. Rebase those commits from HEAD to be signed. These 2 things will help the CI pass.

Erigara
Erigara previously approved these changes Jan 24, 2024
@Arjentix Arjentix self-assigned this Jan 24, 2024
client/tests/integration/tx_chain_id.rs Show resolved Hide resolved
client/tests/integration/tx_chain_id.rs Outdated Show resolved Hide resolved
client/tests/integration/tx_chain_id.rs Outdated Show resolved Hide resolved
client/tests/integration/tx_chain_id.rs Outdated Show resolved Hide resolved
client/tests/integration/tx_chain_id.rs Outdated Show resolved Hide resolved
Co-authored-by: Daniil Polyakov <[email protected]>
Signed-off-by: timofeevmd <[email protected]>
Co-authored-by: Daniil Polyakov <[email protected]>
Signed-off-by: timofeevmd <[email protected]>
timofeevmd and others added 8 commits February 5, 2024 22:31
Co-authored-by: Daniil Polyakov <[email protected]>
Signed-off-by: timofeevmd <[email protected]>
Co-authored-by: Daniil Polyakov <[email protected]>
Signed-off-by: timofeevmd <[email protected]>
Co-authored-by: Daniil Polyakov <[email protected]>
Signed-off-by: timofeevmd <[email protected]>
Co-authored-by: Daniil Polyakov <[email protected]>
Signed-off-by: timofeevmd <[email protected]>
Co-authored-by: Daniil Polyakov <[email protected]>
Signed-off-by: timofeevmd <[email protected]>
Co-authored-by: Daniil Polyakov <[email protected]>
Signed-off-by: timofeevmd <[email protected]>
…re/chainId_test

# Conflicts:
#	client/tests/integration/asset.rs
@timofeevmd timofeevmd closed this Feb 6, 2024
@timofeevmd timofeevmd deleted the feature/chainId_test branch February 6, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants