Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] #3719: Migrate integration Rust tests to client cli pytests #4036

Merged
merged 5 commits into from
Feb 20, 2024
Merged

[refactor] #3719: Migrate integration Rust tests to client cli pytests #4036

merged 5 commits into from
Feb 20, 2024

Conversation

AlexStroke
Copy link
Contributor

@AlexStroke AlexStroke commented Nov 8, 2023

Description

Linked issue

Closes #3719

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Nov 8, 2023
@AlexStroke AlexStroke changed the title [refactor] Migrate integration Rust tests to client cli pytests [refactor] #3719: Migrate integration Rust tests to client cli pytests Nov 8, 2023
@coveralls
Copy link

coveralls commented Nov 8, 2023

Pull Request Test Coverage Report for Build 7099403732

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7032 unchanged lines in 129 files lost coverage.
  • Overall coverage decreased (-3.2%) to 56.266%

Files with Coverage Reduction New Missed Lines %
config/base/derive/src/view.rs 1 99.37%
config/src/block_sync.rs 1 95.0%
config/src/network.rs 1 93.75%
config/src/torii.rs 1 95.45%
config/src/wasm.rs 1 87.5%
core/src/smartcontracts/isi/block.rs 1 87.5%
config/src/kura.rs 2 79.41%
config/src/lib.rs 2 0.0%
ffi/src/option.rs 2 71.43%
config/src/genesis.rs 3 72.92%
Totals Coverage Status
Change from base Build 5423219773: -3.2%
Covered Lines: 23010
Relevant Lines: 40895

💛 - Coveralls

@AlexStroke AlexStroke added Tests python Pull requests that update Python code labels Nov 9, 2023
@AlexStroke AlexStroke marked this pull request as ready for review December 25, 2023 14:52
@coveralls
Copy link

coveralls commented Feb 13, 2024

Pull Request Test Coverage Report for Build 7969560583

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2948 unchanged lines in 53 files lost coverage.
  • Overall coverage decreased (-0.3%) to 56.495%

Files with Coverage Reduction New Missed Lines %
core/src/sumeragi/network_topology.rs 1 98.78%
tools/kagami/src/crypto.rs 1 12.12%
data_model/src/metadata.rs 2 78.87%
primitives/src/unique_vec.rs 2 91.24%
config/src/kura.rs 3 80.0%
config/src/logger.rs 5 72.73%
logger/src/lib.rs 5 94.12%
tools/kagami/src/main.rs 5 0.0%
telemetry/src/dev.rs 7 0.0%
core/src/smartcontracts/isi/mod.rs 8 76.49%
Totals Coverage Status
Change from base Build 7884695009: -0.3%
Covered Lines: 22399
Relevant Lines: 39648

💛 - Coveralls

mversic
mversic previously approved these changes Feb 14, 2024
mversic
mversic previously approved these changes Feb 15, 2024
mversic
mversic previously approved these changes Feb 16, 2024
@mversic mversic requested a review from 0x009922 February 19, 2024 08:10
0x009922
0x009922 previously approved these changes Feb 19, 2024
@AlexStroke AlexStroke dismissed stale reviews from 0x009922 and mversic via df1a64f February 19, 2024 11:57
@AlexStroke AlexStroke merged commit ac3d4c9 into hyperledger-iroha:iroha2-dev Feb 20, 2024
11 checks passed
@alexstroke1 alexstroke1 assigned alexstroke1 and unassigned AlexStroke Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST python Pull requests that update Python code Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants