Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add/clarify log in ISM and Hook deployer #5188

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

jmrossy
Copy link
Contributor

@jmrossy jmrossy commented Jan 15, 2025

Description

Since there's currently no other good way to track deployment progress, the Deploy App watches SDK log messages for its progress indicator. This adds a few logs to help it.

Backward compatibility

Yes

@jmrossy jmrossy requested a review from Xaroz January 15, 2025 20:39
Copy link

changeset-bot bot commented Jan 15, 2025

⚠️ No Changeset found

Latest commit: 1ee7b8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jmrossy jmrossy enabled auto-merge January 15, 2025 20:39
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (1536ea5) to head (1ee7b8c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5188   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@jmrossy jmrossy added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 769cec1 Jan 15, 2025
40 checks passed
@jmrossy jmrossy deleted the rossy/add-ism-and-hook-logs branch January 15, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants