fix(agents/relayer): update metrics even if no new event is found #5178
+32
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5178 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
tkporter
approved these changes
Jan 15, 2025
rust/main/utils/run-locally/src/invariants/termination_invariants.rs
Outdated
Show resolved
Hide resolved
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 16, 2025
) ### Description - Follow up to #5074, the cursor_max_sequence(event_type="merkle_tree_insertion") will be used for the highest merkle index on a chain. The logic to update this metric has been moved to when checking for new logs so we can update the metrics even if new events are not found. - Renamed `latest_leaf_index` to `latest_tree_insertion_index` for clarity. Related #5151 ### Drive-by changes None ### Related issues - fixes hyperlane-xyz/issues#1396 ### Backward compatibility Yes ### Testing e2e + Manual
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
latest_leaf_indextolatest_tree_insertion_indexfor clarity.Related #5151
Drive-by changes
None
Related issues
Backward compatibility
Yes
Testing
e2e + Manual