Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix certificate issue for Cosmos chains #5114

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Conversation

ameten
Copy link
Contributor

@ameten ameten commented Jan 7, 2025

Description

Obsolete version of cosmrs (0.14.0) complains about valid TLS certificates. It makes agents to fail to communicate to Cosmos chains via RPC.

cosmrs 0.16.0 fixes the issue. Some other dependencies also were upgraded.

Related issues

Backward compatibility

Yes

Testing

E2E Cosmos tests and E2E Ethereum and Sealevel tests

Copy link

changeset-bot bot commented Jan 7, 2025

⚠️ No Changeset found

Latest commit: 20a017b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (87d4f63) to head (20a017b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5114   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@ameten ameten changed the title Fix certificate issue for Cosmos chains fix: Fix certificate issue for Cosmos chains Jan 7, 2025
@ameten ameten force-pushed the ameten/cosmos-tls-issue branch from 5f77dff to 20a017b Compare January 9, 2025 12:06
@ameten ameten added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit f3e7fd4 Jan 9, 2025
41 of 42 checks passed
@ameten ameten deleted the ameten/cosmos-tls-issue branch January 9, 2025 18:47
tiendn pushed a commit to tiendn/hyperlane-monorepo that referenced this pull request Jan 11, 2025
### Description

Obsolete version of cosmrs (0.14.0) complains about valid TLS
certificates. It makes agents to fail to communicate to Cosmos chains
via RPC.

cosmrs 0.16.0 fixes the issue. Some other dependencies also were
upgraded.

### Related issues

- Fixes hyperlane-xyz#5113

### Backward compatibility

Yes

### Testing

E2E Cosmos tests and E2E Ethereum and Sealevel tests

---------

Co-authored-by: Danil Nemirovsky <[email protected]>
tiendn pushed a commit to tiendn/hyperlane-monorepo that referenced this pull request Jan 11, 2025
### Description

Obsolete version of cosmrs (0.14.0) complains about valid TLS
certificates. It makes agents to fail to communicate to Cosmos chains
via RPC.

cosmrs 0.16.0 fixes the issue. Some other dependencies also were
upgraded.

### Related issues

- Fixes hyperlane-xyz#5113

### Backward compatibility

Yes

### Testing

E2E Cosmos tests and E2E Ethereum and Sealevel tests

---------

Co-authored-by: Danil Nemirovsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Cosmos RPC certificate issue
2 participants