Upgradable warp routes #3474
Merged
Upgradable warp routes #3474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to use deployAdminAndProxyContracts
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3474 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 1 1
Lines 16 16
=====================================
Misses 16 16
|
…routerContractName to be an abstract getter function. Implement constructorArgs and initializeArgs in token/deploy. Clean up
ltyu
force-pushed
the
upgradable-warp-routes
branch
from
3c4700a to
dd3c182
Compare
nbayindirli
reviewed
Mar 26, 2024
ltyu
force-pushed
the
upgradable-warp-routes
branch
from
4683604 to
4ef2e82
Compare
ltyu
force-pushed
the
upgradable-warp-routes
branch
from
4ef2e82 to
b5b7d8d
Compare
…lasses. Add defaultArgs for 721 deploy
ltyu
force-pushed
the
upgradable-warp-routes
branch
from
45e8d61 to
74c3549
Compare
ltyu
requested review from
yorhodes,
jmrossy,
tkporter and
aroralanuk
as code owners
|
Should merge after #3490 |
yorhodes
approved these changes
Mar 26, 2024
typescript/sdk/src/middleware/account/InterchainAccountDeployer.ts
Outdated
Show resolved
Hide resolved
typescript/sdk/src/middleware/liquidity-layer/LiquidityLayerRouterDeployer.ts
Outdated
Show resolved
Hide resolved
ltyu
force-pushed
the
upgradable-warp-routes
branch
from
f032ab7 to
27ad190
Compare
ltyu
force-pushed
the
upgradable-warp-routes
branch
from
7e74982 to
21e0aa3
Compare
ltyu
force-pushed
the
upgradable-warp-routes
branch
from
21e0aa3 to
901e6c1
Compare
…-xyz/hyperlane-monorepo into upgradable-warp-routes
yorhodes
pushed a commit
that referenced
this pull request
Apr 14, 2024
### Description Makes the following Warp Routes upgradable through CLI deployment ``` - FastHypERC20Collateral - FastHypERC20 - HypERC20 - HypERC20Collateral - HypERC20CollateralVaultDeposit - HypNative - HypNativeScaled - HypERC721Collateral - HypERC721 - HypERC721URICollateral - HypERC721URIStorage ``` - Adds `initialize()` to each contract - It mostly contains `_MailboxClient_initialize`, and any additional proxy specific constructor logic - Refactors - Update `GasRouterDeployer` to inherit from `ProxiedRouterDeployer` - Update `ProxiedRouterDeployer.routerContractName` to `abstract ProxiedRouterDeployer.routerContractName(): RouterKey` . - This allows child classes to specify their own contract name instead of being locked-in to a single name upon construction. Similar concept to the existing `ProxiedRouterDeployer.constructorArgs()` and `ProxiedRouterDeployer.initializeArgs()` - Update `router()` - Add function into `InterchainQueryDeployer` - Add function into `InterchainAccountDeployer` - Update to abstract function in `ProxiedRouterDeployer` - ### Drive-by changes ### Related issues Fixes #999 ### Backward compatibility - Should be backward compatible ### Testing - Updates contract unit tests - Manual testing through CLI and verified contracts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes the following Warp Routes upgradable through CLI deployment
initialize()to each contract_MailboxClient_initialize, and any additional proxy specific constructor logicGasRouterDeployerto inherit fromProxiedRouterDeployerProxiedRouterDeployer.routerContractNametoabstract ProxiedRouterDeployer.routerContractName(): RouterKey.ProxiedRouterDeployer.constructorArgs()andProxiedRouterDeployer.initializeArgs()router()InterchainQueryDeployerInterchainAccountDeployerProxiedRouterDeployerDrive-by changes
Related issues
Fixes #999
Backward compatibility
Testing