Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent warp transfers to zero-ish addresses #3426

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

jmrossy
Copy link
Contributor

@jmrossy jmrossy commented Mar 15, 2024

Description

  • Prevent warp transfers to zero-ish addresses
  • Increase address utility test coverage

Related issues

Fixes #3421

Backward compatibility

Yes

Testing

Tested in warp UI and added unit tests

Increase address utility test coverage
Copy link

changeset-bot bot commented Mar 15, 2024

🦋 Changeset detected

Latest commit: f90d034

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@hyperlane-xyz/utils Patch
@hyperlane-xyz/sdk Patch
@hyperlane-xyz/core Patch
@hyperlane-xyz/cli Patch
@hyperlane-xyz/infra Patch
@hyperlane-xyz/helloworld Patch
@hyperlane-xyz/ccip-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

typescript/utils/src/addresses.ts Show resolved Hide resolved
typescript/utils/src/addresses.ts Show resolved Hide resolved
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Merging #3426 (f90d034) into main (a72c3cf) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3426   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines         16      16           
=====================================
  Misses        16      16           
Components Coverage Δ
core ∅ <ø> (∅)
hooks ∅ <ø> (∅)
isms ∅ <ø> (∅)
token ∅ <ø> (∅)
middlewares ∅ <ø> (∅)

@jmrossy jmrossy merged commit 5daaae2 into main Mar 15, 2024
32 checks passed
@jmrossy jmrossy deleted the rossy/extra-address-validation branch March 15, 2024 19:35
yorhodes pushed a commit that referenced this pull request Mar 22, 2024
### Description

- Prevent warp transfers to zero-ish addresses
- Increase address utility test coverage

### Related issues

Fixes #3421

### Backward compatibility

Yes

### Testing

Tested in warp UI and added unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

WarpCore: prevent transfer to zero-ish addresses
2 participants