Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and Spell check auto integration #3411

Closed
wants to merge 14 commits into from

Conversation

miles-six
Copy link
Contributor

Description

I fixed many typos and want to integrate Spell check to workflow so can fix all typos in the futures

Drive-by changes

Related issues

Backward compatibility

Testing

Copy link

changeset-bot bot commented Mar 13, 2024

⚠️ No Changeset found

Latest commit: 9495b1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jmrossy
Copy link
Contributor

jmrossy commented Mar 13, 2024

Thanks @miles-six for the contribution! A few of these are for receipient, which is a valid variant of recipient. Can you please have that word ignored?

@miles-six
Copy link
Contributor Author

Thanks @miles-six for the contribution! A few of these are for receipient, which is a valid variant of recipient. Can you please have that word ignored?

Yes,I have down it and you even can ignore some words by add to them to .codespell/wordlist.txt

@miles-six
Copy link
Contributor Author

@jmrossy I have added the word 'receipient' to the word.txt file, and it will be ignored in future pull requests.

@@ -135,7 +135,7 @@ impl MigrationTrait for Migration {
"origin_tx"."{tx_egp}" AS "origin_tx_effective_gas_price",
"origin_tx"."{tx_nonce}" AS "origin_tx_nonce",
"origin_tx"."{tx_sender}" AS "origin_tx_sender",
"origin_tx"."{tx_receipient}" AS "origin_tx_recipient",
"origin_tx"."{tx_recipient}" AS "origin_tx_recipient",
Copy link
Contributor

@jmrossy jmrossy Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to please also revert the changes to this database migration file or it will break the Hyperlane explorer

@miles-six
Copy link
Contributor Author

@jmrossy The overall modifications have been a bit chaotic. To avoid delaying the team's work, I will close this pull request and submit a new one with all the changes properly incorporated.!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants