Skip to content

Commit

Permalink
Address PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
jmrossy committed Apr 9, 2024
1 parent 2d9cd6d commit 3806e47
Show file tree
Hide file tree
Showing 7 changed files with 17 additions and 17 deletions.
4 changes: 2 additions & 2 deletions solidity/test/signer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ export async function getSigners(): Promise<Wallet[]> {
}

export async function getSigner(): Promise<Wallet> {
const [signers] = await getSigners();
return signers;
const [signer] = await getSigners();
return signer;
}
2 changes: 1 addition & 1 deletion typescript/infra/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"deploy-helloworld": "tsx scripts/deploy.ts -e test -m helloworld",
"deploy-hook": "tsx scripts/deploy.ts -e test -m hook",
"hardhat-esm": "NODE_OPTIONS='--experimental-loader ts-node/esm/transpile-only --no-warnings=ExperimentalWarning' hardhat --config hardhat.config.cts",
"kathy": "yarn tsx ./scripts/send-random-messages.ts",
"kathy": "yarn tsx ./scripts/send-test-messages.ts",
"prettier": "prettier --write ./src ./config ./scripts ./test",
"test": "yarn test:unit && yarn test:hardhat",
"test:unit": "mocha --config ../sdk/.mocharc.json test/**/*.test.ts",
Expand Down
6 changes: 3 additions & 3 deletions typescript/infra/scripts/middleware/circle-relayer.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import path from 'path';
import { dirname, join } from 'path';
import { fileURLToPath } from 'url';

import {
Expand All @@ -22,8 +22,8 @@ async function check() {
}

const multiProvider = await config.getMultiProvider();
const dir = path.join(
path.dirname(fileURLToPath(import.meta.url)),
const dir = join(
dirname(fileURLToPath(import.meta.url)),
'../../',
getEnvironmentDirectory(environment),
'middleware/liquidity-layer',
Expand Down
6 changes: 3 additions & 3 deletions typescript/infra/scripts/middleware/portal-relayer.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import path from 'path';
import { dirname, join } from 'path';
import { fileURLToPath } from 'url';

import {
Expand All @@ -19,8 +19,8 @@ async function relayPortalTransfers() {
const { environment } = await getArgs().argv;
const config = getEnvironmentConfig(environment);
const multiProvider = await config.getMultiProvider();
const dir = path.join(
path.dirname(fileURLToPath(import.meta.url)),
const dir = join(
dirname(fileURLToPath(import.meta.url)),
'../../',
getEnvironmentDirectory(environment),
'middleware/liquidity-layer',
Expand Down
6 changes: 3 additions & 3 deletions typescript/infra/src/agents/index.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import fs from 'fs';
import path from 'path';
import { dirname, join } from 'path';
import { fileURLToPath } from 'url';

import { ChainName, RpcConsensusType, chainMetadata } from '@hyperlane-xyz/sdk';
Expand Down Expand Up @@ -27,8 +27,8 @@ import { execCmd, isEthereumProtocolChain } from '../utils/utils.js';

import { AgentGCPKey } from './gcp.js';

const HELM_CHART_PATH = path.join(
path.dirname(fileURLToPath(import.meta.url)),
const HELM_CHART_PATH = join(
dirname(fileURLToPath(import.meta.url)),
'/../../../../rust/helm/hyperlane-agent/',
);

Expand Down
10 changes: 5 additions & 5 deletions typescript/infra/src/agents/key-utils.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import path from 'path';
import { dirname, join } from 'path';
import { fileURLToPath } from 'url';

import { ChainMap, ChainName } from '@hyperlane-xyz/sdk';
Expand Down Expand Up @@ -44,8 +44,8 @@ export interface KeyAsAddress {
address: string;
}

const CONFIG_DIRECTORY_PATH = path.join(
path.dirname(fileURLToPath(import.meta.url)),
const CONFIG_DIRECTORY_PATH = join(
dirname(fileURLToPath(import.meta.url)),
'../../config',
);

Expand Down Expand Up @@ -452,8 +452,8 @@ export async function persistRoleAddressesToLocalArtifacts(
addresses[environment][context] = updated;

// Resolve the relative path
const filePath = path.join(
path.dirname(fileURLToPath(import.meta.url)),
const filePath = join(
dirname(fileURLToPath(import.meta.url)),
`../../config/${role}.json`,
);

Expand Down

0 comments on commit 3806e47

Please sign in to comment.