-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: button to go up when search result is less than 10 #1393
base: main
Are you sure you want to change the base?
feat: button to go up when search result is less than 10 #1393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
The PR adds a new 'Go Up' button feature across multiple language files with implementation issues that need to be addressed.
- Translation key 'go_up_buttom' contains a spelling error (should be 'button') consistently across all language files
- Some language files are missing the new translation key entirely, creating inconsistent feature support
- The catalogue.tsx implementation ties button visibility to specific values (10 results, 500px scroll) that should be configurable constants
- The feature's behavior and purpose (appearing for <10 search results) isn't clearly reflected in the translation key naming scheme
💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!
28 file(s) reviewed, 41 comment(s)
Edit PR Review Bot Settings | Greptile
Quality Gate passedIssues Measures |
When submitting this pull request, I confirm the following (please check the boxes):
Fill in the PR content: