Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: button to go up when search result is less than 10 #1393

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

KelvinDiasMoreira
Copy link

@KelvinDiasMoreira KelvinDiasMoreira commented Jan 11, 2025

When submitting this pull request, I confirm the following (please check the boxes):

  • I have read and understood the Contributor Guidelines.
  • I have checked that there are no duplicate pull requests related to this request.
  • I have considered, and confirm that this submission is valuable to others.
  • I accept that this submission may not be used and the pull request may be closed at the discretion of the maintainers.

Fill in the PR content:

image

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

The PR adds a new 'Go Up' button feature across multiple language files with implementation issues that need to be addressed.

  • Translation key 'go_up_buttom' contains a spelling error (should be 'button') consistently across all language files
  • Some language files are missing the new translation key entirely, creating inconsistent feature support
  • The catalogue.tsx implementation ties button visibility to specific values (10 results, 500px scroll) that should be configurable constants
  • The feature's behavior and purpose (appearing for <10 search results) isn't clearly reflected in the translation key naming scheme

💡 (2/5) Greptile learns from your feedback when you react with 👍/👎!

28 file(s) reviewed, 41 comment(s)
Edit PR Review Bot Settings | Greptile

src/locales/ar/translation.json Outdated Show resolved Hide resolved
src/locales/ca/translation.json Outdated Show resolved Hide resolved
src/locales/be/translation.json Outdated Show resolved Hide resolved
src/locales/bg/translation.json Outdated Show resolved Hide resolved
src/locales/da/translation.json Outdated Show resolved Hide resolved
src/locales/zh/translation.json Outdated Show resolved Hide resolved
src/renderer/src/pages/catalogue/catalogue.tsx Outdated Show resolved Hide resolved
src/renderer/src/pages/catalogue/catalogue.tsx Outdated Show resolved Hide resolved
src/renderer/src/pages/catalogue/catalogue.tsx Outdated Show resolved Hide resolved
@KelvinDiasMoreira KelvinDiasMoreira changed the title feat: buttom to go up when search result is less than 10 feat: button to go up when search result is less than 10 Jan 11, 2025
@KelvinDiasMoreira
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant