Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade to munit-cats-effect-0.8.0, curse 0.9.0 #3932

Merged
merged 2 commits into from
Nov 25, 2020
Merged

Downgrade to munit-cats-effect-0.8.0, curse 0.9.0 #3932

merged 2 commits into from
Nov 25, 2020

Conversation

rossabaker
Copy link
Member

Before:

sbt:http4s> show client/fullClasspath
[info] * Attributed(/home/ross/.cache/coursier/v1/https/repo1.maven.org/maven2/org/typelevel/cats-effect_2.13/2.3.0-M1/cats-effect_2.13-2.3.0-M1.jar)

After:

sbt:http4s> show client/fullClasspath
[info] * Attributed(/home/ross/.cache/coursier/v1/https/repo1.maven.org/maven2/org/typelevel/cats-effect_2.13/2.2.0/cats-effect_2.13-2.2.0.jar)

This is confirmed to work in the failing @scala-steward test case, and should help @alexandervanhecke.

Followup work will be done in http4s/sbt-http4s-org#153.

@rossabaker rossabaker added the bug Determined to be a bug in http4s label Nov 25, 2020
@rossabaker rossabaker requested a review from cquiroz November 25, 2020 18:30
@fthomas fthomas mentioned this pull request Nov 25, 2020
Closed
cquiroz
cquiroz approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rossabaker rossabaker merged commit 3abc9fd into series/0.21 Nov 25, 2020
@rossabaker rossabaker deleted the 0.21.13 branch December 28, 2020 18:11
@mergify mergify bot added module:ember-core docs Relates to our website or tutorials labels May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cquiroz cquiroz cquiroz approved these changes

Assignees
No one assigned
Labels
bug Determined to be a bug in http4s docs Relates to our website or tutorials module:ember-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rossabaker @cquiroz