feat: allow multi-line footnotes #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing footnote-body-matching regex requires a space after the label's colon; i.e., the line needs to start like '[^label]: '. This does not provide for multiline footnote bodies, where the first line can end with the ':' and is followed by one or more indented lines. The regex pattern introduced in this commit does not require the existence of subsequent lines, nor that any subsequent lines be indented. Date: Fri Nov 24 15:11:48 2023 -0500 On branch heckman Changes to be committed: modified: CHANGELOG.md modified: README.md modified: package-lock.json modified: package.json modified: src/utils/index.ts modified: test/workspace/test.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Please bear with me as this is the first pull request I have made.
The only thing of consequence that I changed in your code
is the regex on line 4 of
src/utils/index.ts.The other changes were just me attempting to create a new extension.
(I've never made a VS Code extension either.)
—eh
commit message follows
The existing footnote-body-matching regex
requires a space after the label's colon;
i.e., the line needs to start like '[^label]: '.
This does not provide for multiline footnote bodies,
where the first line can end with the ':'
and is followed by one or more indented lines.
The regex pattern introduced in this commit
does not require the existence of subsequent lines,
nor that any subsequent lines be indented.
Date: Fri Nov 24 15:11:48 2023 -0500
On branch heckman
Changes to be committed:
modified: CHANGELOG.md
modified: README.md
modified: package-lock.json
modified: package.json
modified: src/utils/index.ts
modified: test/workspace/test.md