-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config flow to stiebel eltron component #135228
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ThyMYthOS
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @fucm, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
"""Return device specific state attributes.""" | ||
return {"filter_alarm": self._filter_alarm} | ||
|
||
@property | ||
def name(self): | ||
def name(self) -> str: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend doing a preliminary PR where we fix all the typing
Breaking change
Proposed change
This pull request is a first approach to get bronze status for the
stiebel_eltron
integration.Type of change
Additional information
I need some advise how to copy with the fact that a modbus hub is required first in order to setup this integration. Is is possible to perform this setup in the config flow of this integration? Do you have an example how to do it?
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: