Skip to content

Commit

Permalink
Merge pull request #190 from hmrc/DDCNLS-4972
Browse files Browse the repository at this point in the history
DDCNLS-4972:Update new header message in tests and UI
  • Loading branch information
kathaitgunjan authored Oct 26, 2018
2 parents 86fff14 + 89bc199 commit 1295399
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
6 changes: 3 additions & 3 deletions conf/messages
Original file line number Diff line number Diff line change
Expand Up @@ -455,9 +455,9 @@ ated.property-details-value.propertyDetailsValue.partAcqDispDate.error.empty = Y
ated.property-details-value.propertyDetailsValue.valuationDate.error.empty = You must enter a valuation date
ated.property-details-value.propertyDetailsValue.valuationDate-hint = For example, {0}

ated.property-details-value.isPropertyRevalued.title = Have you had the property revalued since you made the £40,000 or more change?
ated.property-details-value.isPropertyRevalued.header = Have you had the property revalued since you made the £40,000 or more change?
ated.property-details-value.isPropertyRevalued = Have you had the property revalued since you made the £40,000 or more change?
ated.property-details-value.isPropertyRevalued.title = Has the property been revalued since the £40,000 or more change?
ated.property-details-value.isPropertyRevalued.header = Has the property been revalued since the £40,000 or more change?
ated.property-details-value.isPropertyRevalued = Has the property been revalued since the £40,000 or more change?
ated.property-details-value.isPropertyRevalued.no-text = The property must be revalued before you can submit this chargeable return
ated.property-details-value.isPropertyRevalued.error = The property must be revalued before you can submit this chargeable return
ated.property-details-value.isPropertyRevalued.error.non-selected = You must answer this question
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ class PropertyDetailsRevaluedControllerSpec extends PlaySpec with OneServerPerSu
result =>
status(result) must be(OK)
val document = Jsoup.parse(contentAsString(result))
document.getElementById("property-details-header").text() must be("Have you had the property revalued since you made the £40,000 or more change?")
document.getElementById("property-details-header").text() must be("Has the property been revalued since the £40,000 or more change?")

document.getElementById("isPropertyRevalued").text() contains ("Yes No")
document.getElementById("revaluedValue_field").text() must be("What is the new valuation of the property in GBP?")
Expand Down
14 changes: 7 additions & 7 deletions test/views/propertyDetails/PropertyDetailsRevaluedSpec.scala
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,13 @@ class PropertyDetailsRevaluedSpec extends FeatureSpec with OneServerPerSuite wit

val document = Jsoup.parse(html.toString())
Then("the page title : Have you had the property revalued since you made the £40,000 change?")
assert(document.title() === "Have you had the property revalued since you made the £40,000 or more change? - GOV.UK")
assert(document.title() === "Has the property been revalued since the £40,000 or more change? - GOV.UK")

Then("The subheader should be - Create return")
assert(document.getElementById("pre-heading").text() === "This section is: Create return")

And("No data is populated")
assert(document.getElementById("isPropertyRevalued").text() === "Have you had the property revalued since you made the £40,000 or more change? Yes No")
assert(document.getElementById("isPropertyRevalued").text() === "Has the property been revalued since the £40,000 or more change? Yes No")
assert(document.getElementById("isPropertyRevalued-true").text() === "")
assert(document.getElementById("isPropertyRevalued-false").text() === "")
assert(document.getElementById("revaluedDate-day").attr("value") === "")
Expand Down Expand Up @@ -103,13 +103,13 @@ class PropertyDetailsRevaluedSpec extends FeatureSpec with OneServerPerSuite wit

val document = Jsoup.parse(html.toString())
Then("the page title : Have you had the property revalued since you made the £40,000 change?")
assert(document.title() === "Have you had the property revalued since you made the £40,000 or more change? - GOV.UK")
assert(document.title() === "Has the property been revalued since the £40,000 or more change? - GOV.UK")

Then("The subheader should be - Change return")
assert(document.getElementById("pre-heading").text() === "This section is: Change return")

And("The data is populated for a property value set to true")
assert(document.getElementById("isPropertyRevalued").text() === "Have you had the property revalued since you made the £40,000 or more change? Yes No")
assert(document.getElementById("isPropertyRevalued").text() === "Has the property been revalued since the £40,000 or more change? Yes No")
assert(document.getElementById("isPropertyRevalued-true").attr("checked") === "checked")
assert(document.getElementById("isPropertyRevalued-false").attr("checked") === "")
assert(document.getElementById("revaluedDate-day").attr("value") === "1")
Expand Down Expand Up @@ -149,10 +149,10 @@ class PropertyDetailsRevaluedSpec extends FeatureSpec with OneServerPerSuite wit

val document = Jsoup.parse(html.toString())
Then("the page title : Have you had the property revalued since you made the £40,000 change?")
assert(document.title() === "Have you had the property revalued since you made the £40,000 or more change? - GOV.UK")
assert(document.title() === "Has the property been revalued since the £40,000 or more change? - GOV.UK")

And("The data is populated for a property value set to false")
assert(document.getElementById("isPropertyRevalued").text() === "Have you had the property revalued since you made the £40,000 or more change? Yes No")
assert(document.getElementById("isPropertyRevalued").text() === "Has the property been revalued since the £40,000 or more change? Yes No")
assert(document.getElementById("isPropertyRevalued-true").attr("checked") === "")
assert(document.getElementById("isPropertyRevalued-false").attr("checked") === "checked")
assert(document.getElementById("revaluedDate-day").attr("value") === "")
Expand Down

0 comments on commit 1295399

Please sign in to comment.