upgrade packages #489
Annotations
10 errors and 11 warnings
Run Linter:
test/integration/scep/common_test.go#L1
: # github.com/smallstep/certificates/test/integration/scep [github.com/smallstep/certificates/test/integration/scep.test]
|
Run Linter:
test/integration/scep/common_test.go#L272
cannot use (*testCAS)(nil) (value of type *testCAS) as "github.com/smallstep/certificates/cas/apiv1".CertificateAuthorityService value in variable declaration: *testCAS does not implement "github.com/smallstep/certificates/cas/apiv1".CertificateAuthorityService (wrong type for method CreateCertificate)
|
Run Linter:
test/integration/scep/decrypter_cas_test.go#L100
cannot use &testCAS{…} (value of type *testCAS) as "github.com/smallstep/certificates/cas/apiv1".CertificateAuthorityService value in return statement: *testCAS does not implement "github.com/smallstep/certificates/cas/apiv1".CertificateAuthorityService (wrong type for method CreateCertificate)
|
Run Linter:
test/integration/scep/regular_cas_test.go#L68
cannot use &testCAS{…} (value of type *testCAS) as "github.com/smallstep/certificates/cas/apiv1".CertificateAuthorityService value in return statement: *testCAS does not implement "github.com/smallstep/certificates/cas/apiv1".CertificateAuthorityService (wrong type for method CreateCertificate)
|
Run Linter:
cmd/step-agent/main.go#L159
unlambda: replace `func(c *cli.Context) error {
|
Run Linter:
go.mod#L190
replacement are not allowed: github.com/smallstep/nosql (gomoddirectives)
|
Run Linter:
cmd/step-agent/main.go#L105
`marshalling` is a misspelling of `marshaling` (misspell)
|
Run Linter:
cas/sectigocas/eab/client.go#L35
unnecessary leading newline (whitespace)
|
Run Linter:
cas/sectigocas/eab/client.go#L48
unnecessary trailing newline (whitespace)
|
Run Linter:
authority/tls.go#L990
unnecessary trailing newline (whitespace)
|
Run Linter
Unexpected input(s) 'skip-pkg-cache', valid inputs are ['version', 'install-mode', 'working-directory', 'github-token', 'only-new-issues', 'skip-cache', 'skip-save-cache', 'annotations', 'args', 'cache-invalidation-interval']
|
Run Linter:
acme/validation/client.go#L57
superfluous-else: if block ends with call to panic function, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
|
Run Linter:
acme/validation/client.go#L9
exported: type name will be used as validation.ValidationResponse by other packages, and that stutters; consider calling this Response (revive)
|
Run Linter:
acme/validation/client.go#L15
exported: type name will be used as validation.ValidationRequest by other packages, and that stutters; consider calling this Request (revive)
|
Run Linter:
cas/vaultcas/vaultcas.go#L175
unused-parameter: parameter 'req' seems to be unused, consider removing or renaming it as _ (revive)
|
Run Linter:
cas/sectigocas/eab/client.go#L30
superfluous-else: if block ends with call to panic function, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
|
Run Linter:
acme/challenge.go#L143
var-naming: var errHttp should be errHTTP (revive)
|
Run Linter:
acme/db/nosql/eab.go#L364
var-naming: don't use underscores in Go names; var err_internal should be errInternal (revive)
|
Run Linter:
cas/sectigocas/sectigocas.go#L34
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
Run Linter:
cas/sectigocas/sectigocas.go#L166
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
Post Run Linter
Unexpected input(s) 'skip-pkg-cache', valid inputs are ['version', 'install-mode', 'working-directory', 'github-token', 'only-new-issues', 'skip-cache', 'skip-save-cache', 'annotations', 'args', 'cache-invalidation-interval']
|
Loading