-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/inline prop #30
base: main
Are you sure you want to change the base?
Feat/inline prop #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! This appears to include your changes from #29, so I'll go review that one first.
i forgot to add the new props on the readme section |
@demetrius-mp Good catch, do you mind adding that here, as well as in #29 ? |
ok, ill add them |
sorry, i definetly messed up something when doing the branches thing. im new to open source 😅 i think that if you close #29 and merge only this PR, it will be ok, since this PR has the commits from #29. this PR has
|
I'd rather have each of these props included as separate commits (makes it easier to revert if there are any issues, plus I it's a nicer commit history to keep things separated). Please address the final comments in #29 and then we can take a look at this PR :) |
ok! |
@demetrius-mp same comment as here, sorry! #29 (comment) |
adds suport for inline prop
closes #5