Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build) Replace deleteSync, which was removed in v6 of del lib #4128

Closed
wants to merge 1 commit into from

Conversation

wkania
Copy link
Contributor

@wkania wkania commented Oct 5, 2024

I'm back and it looks like the following command build_and_test does not work at least since PR

The runner use older version of this lib. This require some sync:

 Starting build.
Finished build.
/home/runner/work/highlight.js/highlight.js/pr/tools/lib/makestuff.js:9
  await del.default([directory]);
                   ^

TypeError: del.default is not a function
    at clean (/home/runner/work/highlight.js/highlight.js/pr/tools/lib/makestuff.js:9:20)
    at async doTarget (/home/runner/work/highlight.js/highlight.js/pr/tools/build.js:89:3)
docker compose exec web npm run build_and_test

> [email protected] build_and_test
> npm run build && npm run test


> [email protected] build
> node ./tools/build.js -t node

Starting build.
Finished build.
/usr/src/service/tools/lib/makestuff.js:9
  del.deleteSync([directory]);
      ^

TypeError: del.deleteSync is not a function
    at clean (/usr/src/service/tools/lib/makestuff.js:9:7)
    at async doTarget (/usr/src/service/tools/build.js:89:3)

Checklist

  • ☑️ Fixed docker compose exec web npm run build_and_test
  • ☑️ Updated the changelog at CHANGES.md

@joshgoebel
Copy link
Member

Working here without issue.

❯ npm list | grep del
├── [email protected]
❯ npm run build_and_test | tail -n10
(node:33088) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)
  zephir
    ✔ should markup default

  robots-txt
    ✔ should markup sample


  1580 passing (1s)
  3 pending

@joshgoebel
Copy link
Member

Closing for inactivity.

@joshgoebel joshgoebel closed this Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants