fix(swift) correctly highlight generics and conformances in type definitions #3937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Size ReportChanges to minified artifacts in 5 files changedTotal change -51 B View Changes
|
|
I know it's not exactly the same thing, but might |
|
@joshgoebel I agree, this better models the semantics here. Please see latest changes. |
bradleymackey
force-pushed
the
fix/swift/generic-sigs
branch
from
d5bce9d to
579626e
Compare
Build Size ReportChanges to minified artifacts in 2 files changedTotal change +20 B View Changes
|
1 similar comment
Build Size ReportChanges to minified artifacts in 2 files changedTotal change +20 B View Changes
|
joshgoebel
reviewed
Dec 24, 2023
joshgoebel
reviewed
Dec 24, 2023
joshgoebel
reviewed
Dec 24, 2023
joshgoebel
requested changes
Dec 24, 2023
Build Size ReportChanges to minified artifacts in 5 files changedTotal change -14 B View Changes
|
joshgoebel
reviewed
Dec 24, 2023
joshgoebel
reviewed
Dec 24, 2023
Build Size ReportChanges to minified artifacts in 4 files changedTotal change -11 B View Changes
|
Build Size ReportChanges to minified artifacts in 5 files changedTotal change -11 B View Changes
|
joshgoebel
force-pushed
the
fix/swift/generic-sigs
branch
from
369e606 to
e3336f3
Compare
Build Size ReportChanges to minified artifacts in 5 files changedTotal change -21 B View Changes
|
joshgoebel
approved these changes
Dec 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes highlighting of type definitions, especially when the given type is generic.
Changes
title.class, only the newly defined type should be highlighted as this. Inheritance and protocol conformances should be indicated with thetitle.class.inheritedclass instead, as this is better modelled by this inheritance class.Checklist
CHANGES.md