Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile String Fix #3898

Merged
merged 2 commits into from
Jul 7, 2024
Merged

Makefile String Fix #3898

merged 2 commits into from
Jul 7, 2024

Conversation

aneesh98
Copy link
Contributor

Resolves #3878

Changes

  1. I have modified the FUNC configuration for Makefile to include QUOTE_STRING so appropriate highlighting gets applied to the string mentioned within a function context

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md

TriMoon
TriMoon suggested changes Oct 23, 2023
View reviewed changes
Copy link

@TriMoon TriMoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my reply: #3878 (comment)

@TriMoon TriMoon mentioned this pull request Nov 14, 2023
Closed
@joshgoebel joshgoebel force-pushed the makefile-string-fix branch from 904ddd1 to 2fd14ca Compare March 21, 2024 01:29
@github-actions GitHub Actions
Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

5 files changed

Total change +15 B

View Changes
file base pr diff
es/core.min.js 8.2 KB 8.2 KB +2 B
es/highlight.min.js 8.2 KB 8.2 KB +2 B
es/languages/makefile.min.js 665 B 669 B +4 B
highlight.min.js 8.23 KB 8.23 KB +3 B
languages/makefile.min.js 673 B 677 B +4 B

@joshgoebel
Copy link
Member

Can you update the changelog?

@joshgoebel
Copy link
Member

ping

@joshgoebel
Copy link
Member

Looks good. Can you please merge/rebase and add attribution to CHANGELOG?

@joshgoebel joshgoebel force-pushed the makefile-string-fix branch from 2fd14ca to afad983 Compare July 7, 2024 02:54
@joshgoebel joshgoebel force-pushed the makefile-string-fix branch from afad983 to 5509a5c Compare July 7, 2024 02:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 7, 2024

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

5 files changed

Total change +10 B

View Changes
file base pr diff
es/core.min.js 8.2 KB 8.2 KB +1 B
es/highlight.min.js 8.2 KB 8.2 KB +1 B
es/languages/makefile.min.js 666 B 669 B +3 B
highlight.min.js 8.23 KB 8.23 KB +1 B
languages/makefile.min.js 673 B 677 B +4 B

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 7, 2024

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

5 files changed

Total change +15 B

View Changes
file base pr diff
es/core.min.js 8.2 KB 8.2 KB +3 B
es/highlight.min.js 8.2 KB 8.2 KB +3 B
es/languages/makefile.min.js 666 B 669 B +3 B
highlight.min.js 8.23 KB 8.23 KB +2 B
languages/makefile.min.js 673 B 677 B +4 B

@joshgoebel joshgoebel merged commit 33eb3d9 into highlightjs:main Jul 7, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TriMoon TriMoon TriMoon requested changes

@joshgoebel joshgoebel joshgoebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(makefile) Syntax highlighting of Makefiles
3 participants
@aneesh98 @joshgoebel @TriMoon