Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement in-browser task search #245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andy-opal
Copy link

@andy-opal andy-opal commented May 18, 2022

This PR implements searching through tasks by keyword, regex or custom JS code. The search is executed in the browser.

Due to the nature of this PR, the implementation has some hacks, please let me know if you have suggestions for better approaches or improvement ideas.

Caveats

  • Searching aggregating tasks is not supported yet
  • As the search is performed in the browser, and since we are restricted to linear search, this approach does not scale very well. However:
    • I have tested it with 100K tasks with each task containing a ~500 char JSON object. The search completes in roughly 10s and JS heap usage increased by 70MB after the search. Therefore I expect this implementation will be fine for at least 1 mil tasks.

Demo video

Screen.Recording.2022-05-17.at.9.31.17.PM-fastflix-70d6_3.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant