Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VB.NET support for several rules #16

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

wolfgang-janz
Copy link

I started to add vb.net support to one of the rules. If you like the approach i am going to add mor vb.net support.

A design question: Is it possiple to share one TooManyArgumentsHighlighting for c# and vb.net by adding an array to the languages of ConfigurableSeverityHighlighting?

@citizenmatt
Copy link
Collaborator

This is awesome, thanks!

As you suggest, you can share a highlight between languages, by adding VBASIC to the languages parameter. Something like:

// The same as "CSHARP,VBASIC"
[ConfigurableSeverityHighlighting(SeverityID, CSharpLanguage.Name + "," + VBLanguage.Name)]
public class TooManyArgumentsHighlighting : Highlighting
{
  // ...
}

If you update the PR with this, I'd be thrilled to merge it :)

I think the approach of effectively duplicating the analyser is probably the best, unfortunately. You could register another interface in the ElementProblemAnalyzer (e.g. (typeof(CSharp.IMethodDeclaration), typeof(VB.IMethodDeclaration)), but then you'd need to take in a base class, (override void Run(ITreeNode …,)) and downcast, and I'm not sure if that would be worth the effort.

Thanks for the PR! I'd love to see more :)

@wolfgang-janz
Copy link
Author

Hi matt,
thank you for thepositive response. I updated my PR.
Didn't update the readme this time.
I am planning to add some more support from time to time :)

@wolfgang-janz wolfgang-janz changed the title feature(): Add TooManyArguments inspection to vb.net feature(): Add TooManyArguments and HollowNames inspection to vb.net Sep 21, 2016
@wolfgang-janz
Copy link
Author

wolfgang-janz commented Sep 21, 2016

In the meanwhile vb.net support for some more inspections

@wolfgang-janz wolfgang-janz changed the title feature(): Add TooManyArguments and HollowNames inspection to vb.net VB.NET support: TooManyArguments and HollowNames inspection to vb.net Sep 26, 2016
@wolfgang-janz wolfgang-janz changed the title VB.NET support: TooManyArguments and HollowNames inspection to vb.net VB.NET support: TooManyArguments, HollowNames, ClassTooBig, TooManyDependencies Sep 26, 2016
@wolfgang-janz wolfgang-janz changed the title VB.NET support: TooManyArguments, HollowNames, ClassTooBig, TooManyDependencies VB.NET support: TooManyArguments, HollowNames, ClassTooBig, TooManyDependencies, MethodTooLong Sep 26, 2016
@wolfgang-janz wolfgang-janz changed the title VB.NET support: TooManyArguments, HollowNames, ClassTooBig, TooManyDependencies, MethodTooLong VB.NET support for several rules Sep 29, 2016
@MO2k4
Copy link

MO2k4 commented Oct 4, 2017

If someone need both vb.net and the new support for resharper 2017.2, come and see my fork

@MO2k4
Copy link

MO2k4 commented Mar 5, 2018

i just released my fork to the resharper gallery, because this project seems dead, feel free to contribute to my fork link

i added your request and added some rules myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants