-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VB.NET support for several rules #16
base: master
Are you sure you want to change the base?
Conversation
This is awesome, thanks! As you suggest, you can share a highlight between languages, by adding // The same as "CSHARP,VBASIC"
[ConfigurableSeverityHighlighting(SeverityID, CSharpLanguage.Name + "," + VBLanguage.Name)]
public class TooManyArgumentsHighlighting : Highlighting
{
// ...
} If you update the PR with this, I'd be thrilled to merge it :) I think the approach of effectively duplicating the analyser is probably the best, unfortunately. You could register another interface in the Thanks for the PR! I'd love to see more :) |
708d0e1
to
3336bbb
Compare
Hi matt, |
In the meanwhile vb.net support for some more inspections |
013ae17
to
b2cdfdf
Compare
b2cdfdf
to
ca8b310
Compare
If someone need both vb.net and the new support for resharper 2017.2, come and see my fork |
i just released my fork to the resharper gallery, because this project seems dead, feel free to contribute to my fork link i added your request and added some rules myself |
I started to add vb.net support to one of the rules. If you like the approach i am going to add mor vb.net support.
A design question: Is it possiple to share one TooManyArgumentsHighlighting for c# and vb.net by adding an array to the languages of ConfigurableSeverityHighlighting?