Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Energy is displaying incorrectly #32

Open
metalvegetarianoprogresivo opened this issue Oct 15, 2019 · 1 comment
Open

UI: Energy is displaying incorrectly #32

metalvegetarianoprogresivo opened this issue Oct 15, 2019 · 1 comment
Labels
bug Something isn't working js Any new issue/pr with JS react ui Changes for the UI

Comments

@metalvegetarianoprogresivo
Copy link
Contributor

The energy cost displayed on the card description has a bug where it shows the total energy cost plus the required energy cost. This should be fixed as follows:

Current:
image

Fixed:
image

Acceptance criteria:

  • Energy cost should be displayed with the generic energy cost followed by the required energy cost.
@metalvegetarianoprogresivo metalvegetarianoprogresivo added bug Something isn't working js Any new issue/pr with JS ui Changes for the UI react labels Oct 15, 2019
RobertoOchoaAldana added a commit to RobertoOchoaAldana/dbs-scraper that referenced this issue Oct 18, 2019
@RobertoOchoaAldana
resolve issue hay-espacio-en-el-taco#32, now generic energy cost is d…
ee8e401 
…isplayed correctly
@Xotl Xotl mentioned this issue Oct 20, 2019
Merged
@metalvegetarianoprogresivo metalvegetarianoprogresivo removed their assignment Oct 27, 2019
Xotl pushed a commit that referenced this issue Nov 12, 2019
@RobertoOchoaAldana @Xotl
Adding functionality to filter buttons (#33)
5bab290 
* adding functionality to filter buttons

* adding EOF lines

* Fixing issue with color filters

* resolve issue #34, now you can click on an active filter button and remove the filter

* fixing issue where comboEnergy was active and clicking on it wouldn't remove the filter

* resolve issue #32, now generic energy cost is displayed correctly

* Deleting semicolons, refactoring the filterbox file, adding hooks

* refactoring the method to create buttons

* added changes so when a filter by same field already exist it will add it as an or into the same filter, also added changes requested by irving

* deleting semicolons
This was referenced Nov 14, 2019
Closed
Merged
@Jarv1193
Copy link
Contributor

Cierren esto tambien

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working js Any new issue/pr with JS react ui Changes for the UI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@metalvegetarianoprogresivo @Jarv1193