Adding functionality to filter buttons (#33) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding functionality to filter buttons * adding EOF lines * Fixing issue with color filters * resolve issue #34, now you can click on an active filter button and remove the filter * fixing issue where comboEnergy was active and clicking on it wouldn't remove the filter * resolve issue #32, now generic energy cost is displayed correctly * Deleting semicolons, refactoring the filterbox file, adding hooks * refactoring the method to create buttons * added changes so when a filter by same field already exist it will add it as an or into the same filter, also added changes requested by irving * deleting semicolons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding functionality to filter buttons
adding EOF lines
Fixing issue with color filters
resolve issue UI: Remove filter when click on an active filter button hay-espacio-en-el-taco/dbs-scraper#34, now you can click on an active filter button and remove the filter
fixing issue where comboEnergy was active and clicking on it wouldn't remove the filter
resolve issue UI: Energy is displaying incorrectly hay-espacio-en-el-taco/dbs-scraper#32, now generic energy cost is displayed correctly
Deleting semicolons, refactoring the filterbox file, adding hooks
refactoring the method to create buttons
added changes so when a filter by same field already exist it will add it as an or into the same filter, also added changes requested by irving
deleting semicolons