Fix invalid joins when the order by relationship predicate is null #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-chambers
force-pushed
the
daniel/fix-order-with-null-predicate
branch
from
6d1c48d to
3f4f926
Compare
| @@ -776,31 +776,32 @@ fn select_for_path_element( | |||
| select.select_list = select_list; | |||
| select.from = Some(from_clause); | |||
|
|
|||
| match predicate { | |||
| None => Ok(select), | |||
| let predicate_tables = RootAndCurrentTables { | |||
There was a problem hiding this comment.
OK, so tl;dr, we were short circuiting too early on None.
danieljharvey
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
If a relationship used in an order by specified a null predicate, the SQL generator would fail to add the join conditions when joining the related table into the query. This would result in an incorrect cross product between the table and the related table.
How
If the relationship predicate is null, we now correctly add the table's join conditions.
Existing tests that assumed all predicates would contain an always true expression have been changed to contain a null predicate and an extra test has been added to cover receiving an always true predicate (to make sure that still works).
Fixes ENG-1386