Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
Gil Mizrahi authored Oct 19, 2023
1 parent 4f64ebb commit 0045afa
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 0 deletions.
2 changes: 2 additions & 0 deletions crates/connectors/ndc-citus/tests/query_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,8 @@ mod sorting {
insta::assert_json_snapshot!(result);
}

// Citus sorts strings differently than PostgreSQL,
// so the 5th row might be different.
#[tokio::test]
async fn sorting_by_nested_relationship_column_with_predicate_exists() {
let result = run_query(
Expand Down
6 changes: 6 additions & 0 deletions crates/connectors/ndc-cockroach/tests/query_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,12 @@ mod sorting {
insta::assert_json_snapshot!(result);
}

// CockroachDB has the opposite default for nulls ordering than PostgreSQL,
// making the test I've written return random results
// (since most tracks are not by Accept, nulls are returned
// first, and we limit the number of results,
// we are not going to get the same result here),
// so we skip the two other sorting with predicate tests.
#[tokio::test]
async fn sorting_by_relationship_count_with_predicate() {
let result = run_query(
Expand Down
2 changes: 2 additions & 0 deletions crates/tests/other-db-tests/src/aurora/query_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,8 @@ mod sorting {
insta::assert_json_snapshot!(result);
}

// Aurora sorts strings differently than PostgreSQL,
// so the 5th row might be different.
#[tokio::test]
async fn sorting_by_nested_relationship_column_with_predicate_exists() {
let result = run_query(
Expand Down

0 comments on commit 0045afa

Please sign in to comment.