Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-21474 Run oidcPeriodicFunc for each namespace id store #29312

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

bosouza
Copy link
Contributor

@bosouza bosouza commented Jan 7, 2025

Description

This PR makes the identity store rotate only the OIDC keys for its own namespace. This allows the enterprise version, which supports namespaces, to scale to a larger number of namespaces without hitting timeouts on this oidcPeriodicFunc by dividing the work between multiple executions. For CE this shouldn't change anything.

ent PR: vault-enterprise#7164
Jira: VAULT-21474

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

not sure why I decided to ignore the NoNamespace error before
or not log the unexpected error, that doesn't make sense.
@bosouza bosouza added this to the 1.19.0-rc milestone Jan 7, 2025
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

CI Results:
All Go tests succeeded! ✅

vault/identity_store_oidc.go Dismissed Show dismissed Hide dismissed
vault/identity_store_oidc.go Dismissed Show dismissed Hide dismissed
vault/identity_store_oidc.go Dismissed Show dismissed Hide dismissed
@bosouza bosouza marked this pull request as ready for review January 8, 2025 21:46
@bosouza bosouza requested review from a team as code owners January 8, 2025 21:46
Copy link

github-actions bot commented Jan 8, 2025

Build Results:
All builds succeeded! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant