move system view interface, grpc server, and client to stubs_oss files #29291
+201
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
CI Results:
|
|
Build Results: |
thyton
added
backport/ent/1.16.x+ent
helenfufu
reviewed
Jan 6, 2025
| @@ -0,0 +1,20 @@ | |||
| // Copyright (c) HashiCorp, Inc. | |||
| // SPDX-License-Identifier: MPL-2.0 | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah, thanks for linking the reference! Though I think I'm confused by what falls under
future releases of HashiCorp products, including HashiCorp Terraform, Vault, Consul, Boundary, Nomad, Waypoint, Packer, and Vagrant
vs.
HashiCorp APIs, SDKs, and almost all other libraries will remain MPL 2.0.
because this is a Vault SDK which seems to satisfy both to me 🤔
helenfufu
previously approved these changes
Jan 6, 2025
helenfufu
previously approved these changes
Jan 7, 2025
fairclothjm
approved these changes
Jan 10, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does this PR do?
This PR refactors dynamic and extended system view interface, its gRPC server, and client to stubs_oss files. The PR prepares for the implementation for the Enterprise internal SDK
Related ENT PR: https://github.com/hashicorp/vault-enterprise/pull/7214
Ticket: VAULT-33084
RFC: https://go.hashi.co/rfc/vlt-337
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.