Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/pb33f/libopenapi from 0.18.2 to 0.18.3 #199

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 8, 2024

Bumps github.com/pb33f/libopenapi from 0.18.2 to 0.18.3.

Release notes

Sourced from github.com/pb33f/libopenapi's releases.

v0.18.3

This fixes vacuum rules that lookup operations in the index where:

The original spec (root.yaml) has an external reference to a file in a different directory ./paths/mypath.yaml In that location, there is a relative reference to a path-item in a nearby file, e.g. ./components.yaml#/path-item What was previously happening in [2] is that the ./components.yaml was being resolved in ./components.yaml (the parent directory) instead of ./paths/components.yaml (the right directory). This resulted in a failure to evaluate path item references and unexpected linting failures.

This changes adjusts the lookup to search through the index's nodeMap to find the location of the YAML $ref node value that's been evaluated. Once we find it, we lookup the associated index of that file and do a seek in that specific index.

We also fix a race condition with resolving the specification asyncronously -- if we are going to an external ref we must do it sequentially as otherwise an index might be added multiple times during an async FindComponent call. This latent bug was exposed as we tested this.

@​ThomasRooney

Commits
  • 4b93cff chore: adjust line size test in windows based on CI runner
  • 8cc9037 chore: fix race condition
  • 5bde18a chore: fix snapshot
  • a9d0af4 chore: add test
  • 71d4143 chore: pass existing tests
  • 9d2e1b8 fix: a parameter in the rolodex should be evaluated using the index that the ...
  • 4d074c3 import for context was wrong.
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/pb33f/libopenapi](https://github.com/pb33f/libopenapi) from 0.18.2 to 0.18.3.
- [Release notes](https://github.com/pb33f/libopenapi/releases)
- [Commits](pb33f/libopenapi@v0.18.2...v0.18.3)

---
updated-dependencies:
- dependency-name: github.com/pb33f/libopenapi
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner October 8, 2024 13:22
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Oct 8, 2024
@austinvalle austinvalle merged commit fac0164 into main Oct 14, 2024
3 checks passed
@austinvalle austinvalle deleted the dependabot/go_modules/github.com/pb33f/libopenapi-0.18.3 branch October 14, 2024 13:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant