Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/cmd: Add kubernetes spec to the golden file tests #121

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

austinvalle
Copy link
Member

Noticed this from a different PR. This golden file needs to be validated in the test. It's already present in the makefile, this just makes sure that you run it. 😄

@austinvalle austinvalle added this to the v0.3.0 milestone Jan 9, 2024
@austinvalle austinvalle requested a review from a team as a code owner January 9, 2024 17:06
@austinvalle austinvalle enabled auto-merge (squash) January 9, 2024 17:06
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@austinvalle austinvalle merged commit 0d4dc1e into main Jan 9, 2024
3 checks passed
@austinvalle austinvalle deleted the av/add-kubernetes-test branch January 9, 2024 17:12
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants