Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: amend HCL templates/functions docs #12672

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

lbajolet-hashicorp
Copy link
Contributor

The HCL2 docs on built-in functions contains a link to a non-existent section of the expressions page, so we update it to link to the general page, and to the string interpolation section, since it is a common use case.

Closes: #12670

@lbajolet-hashicorp lbajolet-hashicorp marked this pull request as ready for review October 27, 2023 19:50
@lbajolet-hashicorp lbajolet-hashicorp requested a review from a team as a code owner October 27, 2023 19:50
@nywilken nywilken added the backport/website Backport PR changes to `stable-website` and latest release branch label Oct 30, 2023
Copy link
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving in advance. Feel free to adjust the suggestions and merged when ready.

The HCL2 docs on built-in functions contains a link to a non-existent
section of the expressions page, so we update it to link to the general
page, and to the string interpolation section, since it is a common use
case.
@lbajolet-hashicorp lbajolet-hashicorp merged commit c528681 into main Oct 30, 2023
10 checks passed
@nywilken nywilken deleted the fix_docs_expressions branch October 30, 2023 17:49
nywilken added a commit that referenced this pull request Nov 8, 2023
This change uses the GitHub CLI to obtain all pull-requests merged after
the latest release to be used for updating the Packer CHANGELOG.

```
~>  ./scripts/prepare_changelog.sh v1.9.4
Update LICENSE text - [GH-12686](#12686)

docs: amend HCL templates/functions docs - [GH-12672](#12672)

build(deps-dev): bump @babel/traverse from 7.17.9 to 7.23.2 in /website - [GH-12658](#12658)

init: warn if no requirements specified - [GH-12638](#12638)

hcl2template: remove value validation for locals - [GH-12620](#12620)

Updating Community Tools webpage - [GH-12612](#12612)

Datasource logic cleanup - [GH-12608](#12608)

version: prepare v1.9.5-dev - [GH-12602](#12602)

Changelog setup 1.9.5 - [GH-12601](#12601)

Update version output for `-v` and `--version` flags - [GH-12569](#12569)
```
@nywilken nywilken added the docs label Nov 10, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/website Backport PR changes to `stable-website` and latest release branch docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Expressions page does not contain Function Calls section
2 participants