Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

Fix bug: table update error while using file view #53

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix bug: table update error while using file view #53

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
99ef114
Merge pull request #1 from harshjv/master
msvamp Jun 24, 2020
c998132
Fix bug: table update error while using file view
msvamp Jun 24, 2020
3cf54b7
Revert "Fix bug: table update error while using file view"
msvamp Jun 24, 2020
024980b
Fix bug: table update error while using file view
msvamp Jun 24, 2020
76e0a73
Better detection of dir view & nav-item bugfixes
msvamp Jun 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions src/inject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,11 @@ const getSizeHTML = (size) => {

return `
<li class="d-flex" id="${NAV_ELEM_ID}">
<a class="js-selected-navigation-item UnderlineNav-item hx_underlinenav-item no-wrap js-responsive-underlinenav-item" data-tab-item="settings-tab" style="cursor: pointer">
<svg class="octicon octicon-gear UnderlineNav-octicon d-none d-sm-inline" display="none inline" aria-hidden="true" height="16" version="1.1" viewBox="0 0 12 16" width="12">
<a class="js-selected-navigation-item UnderlineNav-item hx_underlinenav-item no-wrap js-responsive-underlinenav-item" style="cursor: pointer">
<svg class="octicon octicon-database UnderlineNav-octicon d-none d-sm-inline" display="none inline" aria-hidden="true" height="16" version="1.1" viewBox="0 0 16 16" width="16">
<path d="M6 15c-3.31 0-6-.9-6-2v-2c0-.17.09-.34.21-.5.67.86 3 1.5 5.79 1.5s5.12-.64 5.79-1.5c.13.16.21.33.21.5v2c0 1.1-2.69 2-6 2zm0-4c-3.31 0-6-.9-6-2V7c0-.11.04-.21.09-.31.03-.06.07-.13.12-.19C.88 7.36 3.21 8 6 8s5.12-.64 5.79-1.5c.05.06.09.13.12.19.05.1.09.21.09.31v2c0 1.1-2.69 2-6 2zm0-4c-3.31 0-6-.9-6-2V3c0-1.1 2.69-2 6-2s6 .9 6 2v2c0 1.1-2.69 2-6 2zm0-5c-2.21 0-4 .45-4 1s1.79 1 4 1 4-.45 4-1-1.79-1-4-1z"></path>
</svg>
<span data-content="Settings">${humanReadableSize.size} ${humanReadableSize.measure}</span>
<span>${humanReadableSize.size} ${humanReadableSize.measure}</span>
</a>
</li>
`
Expand Down Expand Up @@ -132,20 +132,24 @@ const checkForRepoPage = async () => {
const ns = document.querySelector('ul.UnderlineNav-body')
const navElem = document.getElementById(NAV_ELEM_ID)
const tdElems = document.querySelector('span.github-repo-size-div')

// whether the files list box has any rows
const viewingDir = document.querySelector('div.Box-row') && true

if (ns && !navElem) {
getAPIData(repoObj.repo).then(summary => {
if (summary && summary.size) {
ns.insertAdjacentHTML('beforeend', getSizeHTML(summary.size * 1024))
const newLiElem = document.getElementById(NAV_ELEM_ID)
newLiElem.title = 'Click to load directory sizes'
newLiElem.style.cssText = 'cursor: pointer'
newLiElem.onclick = loadDirSizes
if(viewingDir) {
newLiElem.title = 'Click to load directory sizes'
newLiElem.onclick = loadDirSizes
}
}
})
}

if (tdElems) return
if (!viewingDir || tdElems) return

const tree = await getAPIData(`${repoObj.repo}/contents/${repoObj.currentPath}?ref=${repoObj.ref}`)
const sizeObj = { '..': '..' }
Expand Down