Wrap GetRecords error in ScanShard #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error message * wrap get records error using %w fmt code * add unit test for kinesis get records using errors.Is
AndreyPiterkin
force-pushed
the
wrap-get-record-error
branch
from
638bc92 to
e062e02
Compare
AndreyPiterkin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #169, if
kinesis.GetRecordsreturns an error and is not retryable, a new error is returned usingfmt.Errorf. However, instead of using the%wformat code which wraps the specified error, %v is used, preventingerrors.Istests from passing on returned errors.Changes