Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KinesisGetRecords error in ScanShard doesn't wrap error if not retryable #169

Open
AndreyPiterkin opened this issue Dec 10, 2024 · 0 comments

Comments

@AndreyPiterkin
Copy link

In ScanShard, if an error is encountered during the Kinesis GetRecords call here: https://github.com/harlow/kinesis-consumer/blob/master/consumer.go#L194-L196

and the error is !isRetriable(err), the error format string grabs the value of the error instead of wrapping it with %w.

This is problematic for my use case, as it is possible that context.CancelFunc is called during the GetRecords call (however unlikely), and I need to check if errors.Is(err, context.Cancelled). Since it is not wrapped, it is impossible for me to tell whether this is the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant