Loop logic bug #844
Merged
Loop logic bug #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ince i starts at 0. The condition should be: i smaller than mapsize, if we want to loop over the mapsize.
haraldk
approved these changes
Oct 21, 2023
|
This is really old code that I haven't looked at in years... I see IntelliJ complains as well. GitHub CodeQL does not though... 😕 I don't know the implications, as this code is obviously not covered by tests. It's probably not used much. But the fix is obviously correct, so we'll just merge it. |
|
Yeah I got it from Intellij. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing the new release come out, I let the old static code analyzer run over things and went over the results, looking for anything interesting. This showed up.
The loop as it was, was never going to run. The condition is "if i is greater than mapsize", which will never be the case, since i starts at 0.
For looping over the mapsize, the condition should be reversed.
I'm unaware if there are serious implications to this never having run, nor what the implications will be now that it will, in terms of process runtime and all that.