Fix crash when zone specific config is missing (#11)

- Zone specific settings are optional, so check if it exists before accessing properties inside it
haraka · Jan 2, 2025 · 6846768 · 6846768
1 parent d4af26c
commit 6846768
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/).
 
 ### Unreleased
 
+- fix: don't crash when zone settings is missing
+
 ### [1.2.1] - 2024-08-22
 
 - fix: don't make a set from a set (happened when periodic_checks < 5), #9

diff --git a/index.js b/index.js
@@ -344,7 +344,7 @@ exports.checkZoneNegative = async function (zone, ip) {
   // IPv4-based DNSxLs MUST NOT contain an entry for 127.0.0.1.
 
   // skip this test for DNS lists that don't follow the RFC
-  if (this.cfg[zone].loopback_is_rejected) return true
+  if (this.cfg[zone]?.loopback_is_rejected) return true
 
   const query = ipQuery(ip, zone)
   try {
@@ -373,7 +373,7 @@ exports.check_zone = async function (zone) {
 
   this.enable_zone(zone) // both tests passed
 
-  if (this.cfg[zone].ipv6 === true) {
+  if (this.cfg[zone]?.ipv6 === true) {
     await this.checkZonePositive(zone, '::FFFF:7F00:2')
     await this.checkZoneNegative(zone, '::FFFF:7F00:1')
   }