[8팀 김도운] [Chapter 2-1] 클린코드와 리팩토링 #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devJayve
changed the title
Comment on lines
+3
to
+57
| export function CartSummary() { | ||
| const element = document.createElement('div'); | ||
| element.id = 'cart-total'; | ||
| element.className = 'text-xl font-bold my-4'; | ||
|
|
||
| const { getCart } = useCart(); | ||
|
|
||
| const calSummary = () => { | ||
| const cart = getCart(); | ||
| let subtotal = 0; | ||
| let totalWithQuantityDiscount = 0; | ||
| let totalQuantity = 0; | ||
|
|
||
| // 각 상품의 수량별 할인 계산 | ||
| cart.forEach(({ product, quantity }) => { | ||
| const itemTotal = product.price * quantity; | ||
| subtotal += itemTotal; | ||
| totalQuantity += quantity; | ||
|
|
||
| if (quantity >= 10) { | ||
| totalWithQuantityDiscount += itemTotal * (1 - product.discountRate); | ||
| } else { | ||
| totalWithQuantityDiscount += itemTotal; | ||
| } | ||
| }); | ||
|
|
||
| // 최종 금액 계산 (수량 할인 vs 대량 구매 할인) | ||
| let finalTotal = totalWithQuantityDiscount; | ||
| let discountRate = (subtotal - totalWithQuantityDiscount) / subtotal || 0; | ||
|
|
||
| // 30개 이상 구매시 25% 할인과 비교 | ||
| if (totalQuantity >= 30) { | ||
| const bulkDiscountTotal = subtotal * 0.75; // 25% 할인 | ||
| if (bulkDiscountTotal < finalTotal) { | ||
| finalTotal = bulkDiscountTotal; | ||
| discountRate = 0.25; | ||
| } | ||
| } | ||
|
|
||
| // 화요일 추가 할인 | ||
| if (new Date().getDay() === 2) { | ||
| const tuesdayDiscount = 0.1; | ||
| discountRate = Math.max(discountRate, tuesdayDiscount); | ||
| finalTotal = subtotal * (1 - discountRate); | ||
| } | ||
|
|
||
| const points = Math.floor(finalTotal / 1000); | ||
|
|
||
| return { | ||
| total: Math.round(finalTotal), | ||
| points, | ||
| discountRate, | ||
| }; | ||
| }; | ||
|
|
There was a problem hiding this comment.
오 주석이 적절한 곳에 있어서 읽기 좋네요!👍
저도 그렇게 느꼈어요.
junman95
reviewed
Jan 11, 2025
| const element = document.createElement('div'); | ||
| element.className = 'flex justify-between items-center mb-2'; | ||
| element.id = product.id; | ||
| const { updateItemQuantity, removeFromCart } = useCart(); |
There was a problem hiding this comment.
리액트 커스텀 훅으로 교체되기 좋은 패턴인 것 같습니다.
도운님 코드는 항상 감동이 있네요..
| <button class="quantity-change bg-blue-500 text-white px-2 py-1 rounded mr-1" data-product-id=${product.id} data-change="1">+</button> | ||
| <button class="remove-item bg-red-500 text-white px-2 py-1 rounded">삭제</button> | ||
| </div> | ||
| `; |
There was a problem hiding this comment.
혹시 여기만 innerHtml형식으로 작업하신 이유가 뭘까요?(시간 이슈..?)
Comment on lines
+3
to
+57
| export function CartSummary() { | ||
| const element = document.createElement('div'); | ||
| element.id = 'cart-total'; | ||
| element.className = 'text-xl font-bold my-4'; | ||
|
|
||
| const { getCart } = useCart(); | ||
|
|
||
| const calSummary = () => { | ||
| const cart = getCart(); | ||
| let subtotal = 0; | ||
| let totalWithQuantityDiscount = 0; | ||
| let totalQuantity = 0; | ||
|
|
||
| // 각 상품의 수량별 할인 계산 | ||
| cart.forEach(({ product, quantity }) => { | ||
| const itemTotal = product.price * quantity; | ||
| subtotal += itemTotal; | ||
| totalQuantity += quantity; | ||
|
|
||
| if (quantity >= 10) { | ||
| totalWithQuantityDiscount += itemTotal * (1 - product.discountRate); | ||
| } else { | ||
| totalWithQuantityDiscount += itemTotal; | ||
| } | ||
| }); | ||
|
|
||
| // 최종 금액 계산 (수량 할인 vs 대량 구매 할인) | ||
| let finalTotal = totalWithQuantityDiscount; | ||
| let discountRate = (subtotal - totalWithQuantityDiscount) / subtotal || 0; | ||
|
|
||
| // 30개 이상 구매시 25% 할인과 비교 | ||
| if (totalQuantity >= 30) { | ||
| const bulkDiscountTotal = subtotal * 0.75; // 25% 할인 | ||
| if (bulkDiscountTotal < finalTotal) { | ||
| finalTotal = bulkDiscountTotal; | ||
| discountRate = 0.25; | ||
| } | ||
| } | ||
|
|
||
| // 화요일 추가 할인 | ||
| if (new Date().getDay() === 2) { | ||
| const tuesdayDiscount = 0.1; | ||
| discountRate = Math.max(discountRate, tuesdayDiscount); | ||
| finalTotal = subtotal * (1 - discountRate); | ||
| } | ||
|
|
||
| const points = Math.floor(finalTotal / 1000); | ||
|
|
||
| return { | ||
| total: Math.round(finalTotal), | ||
| points, | ||
| discountRate, | ||
| }; | ||
| }; | ||
|
|
There was a problem hiding this comment.
오 주석이 적절한 곳에 있어서 읽기 좋네요!👍
저도 그렇게 느꼈어요.
| element.innerHTML = products | ||
| .filter((product) => product.quantity === 0) | ||
| .map((product) => `<span>${product.name}: 품절</span>`) | ||
| .join(''); |
| getMessage: (product) => `${product.name}은(는) 어떠세요? 지금 구매하시면 5% 추가 할인!`, | ||
| priceRate: 0.05, | ||
| }, | ||
| }; |
There was a problem hiding this comment.
속성 네이밍이나 객체 분리가 너무 좋은 것 같아요.
객체 변수명은 Config가 들어가는 이유가 무엇일까요??
| let instance = null; | ||
|
|
||
| export function useCart() { | ||
| if (instance) return instance; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
과제 체크포인트
기본과제
심화과제
과제 셀프회고
과제에서 좋았던 부분
과제를 하면서 새롭게 알게된 점
과제를 진행하면서 아직 애매하게 잘 모르겠다 하는 점, 혹은 뭔가 잘 안되서 아쉬운 것들
리뷰 받고 싶은 내용이나 궁금한 것에 대한 질문