Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13팀 김유진] [Chapter 2-1] 클린코드와 리팩토링 #40

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

[13팀 김유진] [Chapter 2-1] 클린코드와 리팩토링 #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
dd6eb8b
♻️ refactor: Prettier를 통해 일관된 포맷팅 적용
yireum Jan 6, 2025
c4c1b11
♻️ refactor: 줄바꿈과 주석을 사용하여 코드의 논리적 단위를 구분
yireum Jan 6, 2025
11575b6
♻️ refactor: 변수명과 함수명 수정
yireum Jan 6, 2025
13b1201
♻️ refactor: 매직 넘버와 문자열 상수 추출
yireum Jan 6, 2025
0172e41
♻️ refactor: 중복 코드를 제거하고 utils 함수 분리
yireum Jan 6, 2025
80d7b81
♻️ refactor: 단일 책임 원칙에 따라 processCartChanges 수정
yireum Jan 6, 2025
76e41bb
♻️ refactor: calculateDiscounts, calculateItemTotals 함수 개선
yireum Jan 7, 2025
734eab9
♻️ refactor: 의존성 순서대로 배치 수정
yireum Jan 7, 2025
c6a2962
♻️ refactor: 기능별 모듈화 및 JSDoc 적용
yireum Jan 7, 2025
0134329
♻️ refactor: ES6+ 문법을 활용하여 개선
yireum Jan 7, 2025
7dbcae2
♻️ refactor: side effects 최소화
yireum Jan 7, 2025
da217d2
♻️ refactor: updateItemQuantity 예외처리 추가
yireum Jan 7, 2025
8d133fd
♻️ refactor: 자기 문서화 위해 변수명 수정
yireum Jan 7, 2025
18b4e3b
♻️ refactor: 비즈니스 로직과 UI 로직 분리
yireum Jan 8, 2025
fb1a5cd
♻️ refactor: DOM 조작 최적화 및 재고 관리 성능 개선, 주석 정리
yireum Jan 8, 2025
0097e59
🐛 fix: original, basic 파일 교체..
yireum Jan 8, 2025
89299dc
♻️ refactor: advanced React/ Typescript로 고도화
yireum Jan 9, 2025
3cab8f0
♻️ refactor: 팀 컨벤션 - 전역변수 안쓰기
yireum Jan 9, 2025
94ca255
♻️ refactor: 복수의 변수명은 +List로 작명, 이벤트 핸들러는 handle로 시작
yireum Jan 9, 2025
6285bef
♻️ refactor: 축약어 규칙에 맞춰 수정
yireum Jan 9, 2025
2d18f9e
🐛 fix: 코드 삭제 된 파일 오류 수정, 빠진 축약어 수정
yireum Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.advanced.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@
</head>
<body class="bg-gray-100 p-8">
<main id="app"></main>
<script type="module" src="./src/advanced/main.advanced.js"></script>
<script type="module" src="./src/advanced/main.advanced.tsx"></script>
</body>
</html>
15 changes: 12 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,30 @@
"type": "module",
"scripts": {
"dev": "vite",
"build": "vite build",
"build": "tsc && vite build",
"preview": "vite preview",
"start:basic": "vite serve --open ./index.basic.html",
"start:advanced": "vite serve --open ./index.advanced.html",
"test": "vitest",
"test:basic": "vitest basic.test.js",
"test:advanced": "vitest advanced.test.js",
"test:advanced": "vitest advanced.test.tsx",
"test:ui": "vitest --ui"
},
"devDependencies": {
"@testing-library/jest-dom": "^6.5.0",
"@testing-library/jest-dom": "^6.6.3",
"@testing-library/react": "^16.1.0",
"@testing-library/user-event": "^14.5.2",
"@vitejs/plugin-react": "^4.3.4",
"@vitest/ui": "^2.1.1",
"jsdom": "^25.0.0",
"vite": "^5.1.0",
"vitest": "^2.1.1"
},
"dependencies": {
"@types/react": "^19.0.4",
"@types/react-dom": "^19.0.2",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"typescript": "^5.7.3"
}
}
Loading
Loading