fix: fix docker build on CI

hamzzy · Nov 19, 2024 · c79689b · c79689b
1 parent eb0ade2
commit c79689b
Showing 1 changed file with 11 additions and 7 deletions.
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -46,15 +46,19 @@ jobs:
       run: npm run build
 
     # Docker build and push
+        # Log in to Docker Hub
+    - name: Log in to Docker Hub
+      uses: docker/login-action@v2
+      with:
+        username: ${{ secrets.DOCKER_USERNAME }}
+        password: ${{ secrets.DOCKER_PASSWORD }}
+
+      # Build and push Docker image
     - name: Build and Push Docker Image
-      env:
-        DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
-        DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
       run: |
-        echo $DOCKER_PASSWORD | docker login -u $DOCKER_USERNAME --password-stdin
-        docker build -t $DOCKER_USERNAME/fxql:${{ github.sha }} -t $DOCKER_USERNAME/fxql:latest .
-        docker push $DOCKER_USERNAME/fxql:${{ github.sha }}
-        docker push $DOCKER_USERNAME/fxql:latest
+        docker build -t ${{ secrets.DOCKER_USERNAME }}/fxql:${{ github.sha }} -t ${{ secrets.DOCKER_USERNAME }}/fxql:latest .
+        docker push ${{ secrets.DOCKER_USERNAME }}/fxql:${{ github.sha }}
+        docker push ${{ secrets.DOCKER_USERNAME }}/fxql:latest
     
     # Deploy to Railway
     - name: Deploy to Railway