Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add location RSVP to tavern page #1120

Merged
merged 5 commits into from
Jan 21, 2025
Merged

Add location RSVP to tavern page #1120

merged 5 commits into from
Jan 21, 2025

Conversation

malted
Copy link
Member

@malted malted commented Jan 21, 2025

No description provided.

Copy link

vercel bot commented Jan 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
high-seas 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 5:43pm

@malted malted merged commit c54b63e into main Jan 21, 2025
2 of 3 checks passed
@malted malted deleted the malted/rsvp-specifics branch January 21, 2025 17:44
@polytroper
Copy link
Collaborator

polytroper commented Jan 21, 2025

image

If I select anything other than "attendee" I get a loading thingy

When I select attendee, it does not auto-select the tavern closest to me (and move the map)

The taverns in the dropdown do not indicate if they still need an organizer

When I select a tavern that still needs an organizer it does not tell me that an organizer is needed

Finally, a couple new requirements I didn't list before:

  • Let's sort the list of events alphabetically first by country, then subsorted by city. The list is impossible to navigate right now
  • When I select an event, it should link the channel_link field on that tavern record with some text like "Make sure to join this tavern's organizing channel on slack!"

@polytroper
Copy link
Collaborator

Another important thing, this is linking the wrong field for attendees. The correct field on people is called taverns_attendee

@polytroper
Copy link
Collaborator

Also, when I switch myself to "organizer" it does not link me as an organizer (though this could be because of an error caused by my renaming of the improperly-named taverns field on people to taverns_potential_organizer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants