Merge pull request #700 from gundam-organization/main

update from wrong branch
gundam-organization · Nov 28, 2024 · ebb4b9d · ebb4b9d
2 parents 83160bb + b5889de
commit ebb4b9d
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 1 deletion.
diff --git a/resources/images/README/title.key b/resources/images/README/title.key
diff --git a/resources/images/README/title/title.001.png b/resources/images/README/title/title.001.png
diff --git a/resources/images/organisation/logo.key b/resources/images/organisation/logo.key
diff --git a/resources/images/organisation/logo/logo.001.png b/resources/images/organisation/logo/logo.001.png
diff --git a/src/StatisticalInference/JointProbability/include/BarlowBeestonBanff2022.h b/src/StatisticalInference/JointProbability/include/BarlowBeestonBanff2022.h
@@ -26,7 +26,7 @@ namespace JointProbability{
     void printConfiguration() const;
 
     mutable int verboseLevel{0};
-    bool throwIfInfLlh{false};
+    bool throwIfInfLlh{true};
     bool allowZeroMcWhenZeroData{true};
     bool usePoissonLikelihood{false};
     bool BBNoUpdateWeights{false}; // OA 2021 bug reimplementation
@@ -72,6 +72,11 @@ namespace JointProbability{
     double dataVal = samplePair_.data->getHistogram().getBinContentList()[bin_].sumWeights;
     double predVal = samplePair_.model->getHistogram().getBinContentList()[bin_].sumWeights;
 
+    if( predVal == 0 ){
+      LogError << bin_ << " bin predicting 0 rate -> llh not defined / inf" << std::endl;
+      LogError << samplePair_.model->getSummary() << std::endl;
+    }
+
     {
       /// the first time we reach this point, we assume the predMC is at its nominal value
       std::lock_guard<std::mutex> g(_mutex_);