[Test] Rework PR Gate #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very clean! And I've never done it that way so glad to learn. |
|
I think this looks reasonable to me. @nopdive might have some thoughts too |
Harsha-Nori
reviewed
Apr 29, 2024
Comment on lines
+121
to
+122
| # Third Stage ============================================================== | ||
| # Windows and MacOS, plus other GPU Linux tests |
There was a problem hiding this comment.
Appreciate the cascaded staging :), and the structure seems reasonable!
|
Have merged for now, but am willing to make further changes in future. The cascading of stages is a bit involved; I'd happily simplify it, if we were testing fewer Python versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to improve how the GitHub workflows are built. Inspired by #758 by @ryanpeach