Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Enable transformers_mistral_7b #741

Closed

Conversation

riedgar-ms
Copy link
Collaborator

@riedgar-ms riedgar-ms commented Apr 2, 2024

A tokenizer issue (#713 ) was causing problems in some of our builds. PR #740 should have fixed this, so enable the tests.

@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.30%. Comparing base (acb38d1) to head (75d8b5f).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #741      +/-   ##
==========================================
+ Coverage   55.37%   62.30%   +6.93%     
==========================================
  Files          55       55              
  Lines        4074     4070       -4     
==========================================
+ Hits         2256     2536     +280     
+ Misses       1818     1534     -284     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@slundberg
Copy link
Collaborator

@riedgar-ms what is the state of this PR? Happy to look it over, but not sure if it is ready for that

@riedgar-ms
Copy link
Collaborator Author

@slundberg current status is waiting for me to get around to trying to run it again

@riedgar-ms
Copy link
Collaborator Author

This is out of date, and we're rethinking how the tests are organised.

@riedgar-ms riedgar-ms closed this Jun 5, 2024
@riedgar-ms riedgar-ms deleted the riedgar-ms/enable-transformers-7b branch August 26, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants