[Feature] Allow json-loads-able strings to be passed as schema #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1028 +/- ##
==========================================
- Coverage 65.53% 64.18% -1.35%
==========================================
Files 63 63
Lines 4842 4844 +2
==========================================
- Hits 3173 3109 -64
- Misses 1669 1735 +66 ☔ View full report in Codecov by Sentry. |
hudson-ai
force-pushed
the
json_string_schemas
branch
from
d31faa8 to
67f0b4b
Compare
|
@Harsha-Nori @riedgar-ms ping :) |
riedgar-ms
reviewed
Oct 22, 2024
| @@ -937,7 +938,9 @@ def json( | |||
| # Default schema is empty, "anything goes" schema | |||
| # TODO: consider default being `{"type": "object"}` | |||
| schema = {} | |||
| elif isinstance(schema, (Mapping, bool)): | |||
| elif isinstance(schema, (Mapping, bool, str)): | |||
| if isinstance(schema, str): | |||
There was a problem hiding this comment.
@riedgar-ms done :)
riedgar-ms
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.